Bug 78122 - Add support for the contains value for line grid snapping.
Summary: Add support for the contains value for line grid snapping.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-08 09:05 PST by Dave Hyatt
Modified: 2022-10-25 15:12 PDT (History)
1 user (show)

See Also:


Attachments
Patch (35.99 KB, patch)
2012-02-08 09:07 PST, Dave Hyatt
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2012-02-08 09:05:10 PST
Add support for the contains value for line grid snapping, so that it is possible to center headers etc. in between grid lines.
Comment 1 Dave Hyatt 2012-02-08 09:07:42 PST
Created attachment 126097 [details]
Patch
Comment 2 Adam Roben (:aroben) 2012-02-08 09:27:31 PST
Comment on attachment 126097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126097&action=review

> Source/WebCore/rendering/RootInlineBox.cpp:377
> +    LayoutUnit result = delta;

This can go back down to line 400 where it was before this patch.
Comment 3 Ahmad Saleem 2022-10-25 15:12:37 PDT
This landed and didn't backed out:

https://github.com/WebKit/WebKit/commit/fdbea2888836ce2136d22e6c746596db7767e8ad

Marking this as "RESOLVED FIXED".