Bug 78118 - [GTK] Fails to build docs with non-standard build directories
Summary: [GTK] Fails to build docs with non-standard build directories
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gustavo Noronha (kov)
Keywords: Gtk
Depends on:
Reported: 2012-02-08 08:36 PST by Gustavo Noronha (kov)
Modified: 2012-02-08 09:32 PST (History)
1 user (show)

See Also:

Patch (1.27 KB, patch)
2012-02-08 08:41 PST, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2012-02-08 08:36:35 PST
So in Debian and Ubuntu our webkit package builds the two flavors of WebkitGTK+: gtk2 and gtk3. We use build-2.0 to build the former and build-3.0 for the later. We get this error after the gtk-doc stuff changed:

Could not determine build directory.
make[1]: *** [docs-build.stamp] Error 1

A patch is forthcoming.
Comment 1 Gustavo Noronha (kov) 2012-02-08 08:41:01 PST
Created attachment 126089 [details]
Comment 2 Martin Robinson 2012-02-08 09:11:53 PST
Comment on attachment 126089 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=126089&action=review

> Tools/gtk/common.py:70
> +    build_dir = os.getcwd()
> +    if is_valid_build_directory(build_dir):
> +        return build_dir
> +

I think you should drop a comment here explaining this is necessary. Might also want to mention who had the problem originally (Debian downstream), so that in the future we know who ask about it if the code is moved around.
Comment 3 WebKit Review Bot 2012-02-08 09:32:00 PST
Comment on attachment 126089 [details]

Clearing flags on attachment: 126089

Committed r107098: <http://trac.webkit.org/changeset/107098>
Comment 4 WebKit Review Bot 2012-02-08 09:32:04 PST
All reviewed patches have been landed.  Closing bug.