Bug 78113 – Web Inspector: heap snapshot: implement Distance column in Object's retaining tree.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

%subj%

[Ilya Tikhonovsky]

Created attachment 126076 [details]
Patch

[Yury Semikhatsky]

I'm not sure that we need to see this column in the UI. It doesn't provide much additional information about the retainers.

[Yury Semikhatsky]

Comment on attachment 126076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126076&action=review

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:436
> +            distanceToWindow: ["distanceToWindow", sortAscending, "_name", true]

Please make sure sorting by the distance column works if there are expanded entries. r- for this.

[Ilya Tikhonovsky]

Created attachment 126087 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 126087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126087&action=review

> Source/WebCore/inspector/front-end/HeapSnapshot.js:946
> +        this._distancesToWindow = new Array(this.nodeCount);

Use {} instead of array?

> Source/WebCore/inspector/front-end/HeapSnapshot.js:969
> +            var node = list[index++]; // shift generates too much garbage.

Why not just use shift here?

[Ilya Tikhonovsky]

Comment on attachment 126087 [details]
Patch

Clearing flags on attachment: 126087

Committed r107106: <http://trac.webkit.org/changeset/107106>

[Ilya Tikhonovsky]

All reviewed patches have been landed.  Closing bug.

[Mikhail Naganov]

Comment on attachment 126087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126087&action=review

> Source/WebCore/inspector/front-end/HeapSnapshot.js:978
> +                if (typeof this._distancesToWindow[childNode.nodeIndex] !== "undefined")

Drive-by: "if (childNode.nodeIndex in this._distancesToWindow)" is shorter