Bug 78112 - Web Inspector: do not clear entire tree map upon last element deletion.
Summary: Web Inspector: do not clear entire tree map upon last element deletion.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-08 06:16 PST by Pavel Feldman
Modified: 2012-02-09 10:21 PST (History)
10 users (show)

See Also:


Attachments
Patch (1.37 KB, patch)
2012-02-08 06:19 PST, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-02-08 06:16:29 PST
Patch to follow.
Comment 1 Pavel Feldman 2012-02-08 06:19:08 PST
Created attachment 126071 [details]
Patch
Comment 2 Pavel Feldman 2012-02-08 06:49:43 PST
Committed r107083: <http://trac.webkit.org/changeset/107083>
Comment 3 Timothy Hatcher 2012-02-08 13:20:08 PST
Comment on attachment 126071 [details]
Patch

What user affect does this fix?
Comment 4 Pavel Feldman 2012-02-09 04:14:33 PST
(In reply to comment #3)
> (From update of attachment 126071 [details])
> What user affect does this fix?

I noticed it when I was testing the new F2 shortcut for toggling edit as html. Entire representedObject -> treeElement binding (starting from root, including the <html> node) was wiped out upon tree element deletion. After that, actions that were relying upon the binding were failing.

Why do you ask? Do you agree with it or are you assessing the damage it was producing?
Comment 5 Timothy Hatcher 2012-02-09 10:21:24 PST
Just assessing the damage it was producing. Thanks!