Bug 78098 - [GTK] Show url of current hovered link in MiniBrowser
Summary: [GTK] Show url of current hovered link in MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 78097
Blocks: 71447
  Show dependency treegraph
 
Reported: 2012-02-08 03:19 PST by Carlos Garcia Campos
Modified: 2012-02-09 09:18 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.60 KB, patch)
2012-02-08 03:22 PST, Carlos Garcia Campos
mrobinson: review+
pnormand: commit-queue-
Details | Formatted Diff | Diff
Patch updated to current git master (2.56 KB, patch)
2012-02-09 08:53 PST, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-02-08 03:19:19 PST
This was implemented when MiniBrowser used the C API
Comment 1 Carlos Garcia Campos 2012-02-08 03:22:26 PST
Created attachment 126044 [details]
Patch
Comment 2 Philippe Normand 2012-02-08 03:25:52 PST
Comment on attachment 126044 [details]
Patch

Attachment 126044 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11453359
Comment 3 Carlos Garcia Campos 2012-02-08 03:30:49 PST
(In reply to comment #2)
> (From update of attachment 126044 [details])
> Attachment 126044 [details] did not pass gtk-ews (gtk):
> Output: http://queues.webkit.org/results/11453359

This is because it depends on bug #78097
Comment 4 Martin Robinson 2012-02-08 08:23:28 PST
Comment on attachment 126044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126044&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:165
>      g_signal_connect(menu, "hide", G_CALLBACK(resetStatusText), window);

I guess this comment was incorrect?
Comment 5 Carlos Garcia Campos 2012-02-09 08:53:07 PST
Created attachment 126313 [details]
Patch updated to current git master
Comment 6 Carlos Garcia Campos 2012-02-09 09:18:24 PST
Committed r107254: <http://trac.webkit.org/changeset/107254>