Bug 78096 - Rename [HasNumericIndexGetter] to [NumericIndexedGetter]
Summary: Rename [HasNumericIndexGetter] to [NumericIndexedGetter]
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 77393
  Show dependency treegraph
Reported: 2012-02-08 02:54 PST by Kentaro Hara
Modified: 2012-02-08 23:22 PST (History)
5 users (show)

See Also:

Patch (19.97 KB, patch)
2012-02-08 02:58 PST, Kentaro Hara
abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
rebased patch for commit (20.00 KB, patch)
2012-02-08 16:08 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-08 02:54:24 PST
We can rename [HasNumericIndexGetter] to [NumericIndexedGetter], for naming consistency with [IndexedGetter] and [CustomIndexedGetter].
Comment 1 Kentaro Hara 2012-02-08 02:58:25 PST
Created attachment 126040 [details]
Comment 2 WebKit Review Bot 2012-02-08 15:29:04 PST
Comment on attachment 126040 [details]

Rejecting attachment 126040 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10594 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 10594.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11462602
Comment 3 Kentaro Hara 2012-02-08 16:08:19 PST
Created attachment 126176 [details]
rebased patch for commit
Comment 4 WebKit Review Bot 2012-02-08 22:43:34 PST
Comment on attachment 126176 [details]
rebased patch for commit

Clearing flags on attachment: 126176

Committed r107181: <http://trac.webkit.org/changeset/107181>