Bug 78089 - Remove [CustomHeader] from CanvasPixelArray and rename [CustomHeader] to [JSCustomHeader]
Summary: Remove [CustomHeader] from CanvasPixelArray and rename [CustomHeader] to [JSC...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 77393
  Show dependency treegraph
 
Reported: 2012-02-08 01:39 PST by Kentaro Hara
Modified: 2012-02-08 15:15 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.64 KB, patch)
2012-02-08 01:41 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-08 01:39:13 PST
We can remove [CustomHeader] from CanvasPixelArray.idl, since CanvasPixelArrayCustom.h does not exist. (The reason why missing CanvasPixelArrayCustom.h has not caused build failure is that [CustomHeader] has been JSC-specific and JSC has not enabled CanvasPixelArray.)

Also, we can rename [CustomHeader] to [JSCustomHeader], since whether a given class should have custom header or not will depend on JavaScript bindings.
Comment 1 Kentaro Hara 2012-02-08 01:41:59 PST
Created attachment 126027 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-08 15:15:01 PST
Comment on attachment 126027 [details]
Patch

Clearing flags on attachment: 126027

Committed r107137: <http://trac.webkit.org/changeset/107137>
Comment 3 WebKit Review Bot 2012-02-08 15:15:06 PST
All reviewed patches have been landed.  Closing bug.