Bug 78086 - Web Inspector: hovering over element with :hover style halts inspector
Summary: Web Inspector: hovering over element with :hover style halts inspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-08 01:18 PST by Pavel Feldman
Modified: 2012-02-09 01:51 PST (History)
13 users (show)

See Also:


Attachments
Patch (5.81 KB, patch)
2012-02-08 05:04 PST, Alexander Pavlov (apavlov)
no flags Details | Formatted Diff | Diff
Patch (5.93 KB, patch)
2012-02-08 07:37 PST, Alexander Pavlov (apavlov)
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-02-08 01:18:33 PST
- Inspect the inspector
- Choose inspect element on one of the watch expressions
- Select <li> in the elements panel
- Hover over the watch expression in the UI

Actual: inspector front-end hangs

The reason is that while moving the mouse over the watch expression, Element::didModifyAttribute is called and propagated to InspectorInstrumentation::didModifyDOMAttr hundreds time a second. There is no throttling, so front-end is trying to update styles infinite amount of times.
Comment 1 Alexander Pavlov (apavlov) 2012-02-08 05:04:08 PST
Created attachment 126062 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-08 05:39:10 PST
Comment on attachment 126062 [details]
Patch

Attachment 126062 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11461399

New failing tests:
inspector/styles/commit-selector.html
inspector/styles/styles-change-node-while-editing.html
inspector/styles/override-screen-size.html
inspector/styles/styles-disable-inherited.html
Comment 3 Pavel Feldman 2012-02-08 06:37:45 PST
Comment on attachment 126062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126062&action=review

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:240
> +        this._executeRebuildUpdateTimer = setTimeout(this._executeRebuildUpdate.bind(this, node, callback));

As we agreed offline, we should not rely on the atomic nature of incoming event sequences.
Comment 4 Alexander Pavlov (apavlov) 2012-02-08 07:37:00 PST
Created attachment 126082 [details]
Patch
Comment 5 Alexander Pavlov (apavlov) 2012-02-09 01:51:47 PST
Committed r107201: <http://trac.webkit.org/changeset/107201>