This is the BlackBerry implement of InspectorClient.
Created attachment 126009 [details] Patch
Comment on attachment 126009 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126009&action=review Looks good, can be cleaned up a bit more. > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp:25 > +#include "FrameView.h" Do you need this include? > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp:26 > +#include "IntRect.h" Ditto. > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp:27 > +#include "IntSize.h" Ditto. > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp:132 > + CString utf8Message = message.utf8(); CString utf8Message = message.utf8(); > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h:24 > +#include "IntRect.h" Do you need this include?
Created attachment 126219 [details] Patch v2
Comment on attachment 126219 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=126219&action=review Looks good! > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h:56 > + virtual void clearBrowserCookies(); Better add an empty line here.
(In reply to comment #4) > (From update of attachment 126219 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=126219&action=review > > Looks good! > > > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h:56 > > + virtual void clearBrowserCookies(); > > Better add an empty line here. Thanks. I will add a blank line before landing.
Committed r107169: <http://trac.webkit.org/changeset/107169>