RESOLVED FIXED Bug 78076
Rename [HasOverridingNameGetter] attribute to [CustomNamedGetter] attribute 
https://bugs.webkit.org/show_bug.cgi?id=78076
Summary Rename [HasOverridingNameGetter] attribute to [CustomNamedGetter] attribute
Kentaro Hara
Reported 2012-02-07 21:26:31 PST
We can rename the [HasOverridingNameGetter] attribute to the [CustomNamedGetter] attribute, for naming consistency with [CustomNamedSetter].
Attachments
Patch (15.47 KB, patch)
2012-02-07 21:29 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for commit (126.72 KB, patch)
2012-02-07 21:41 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-07 21:29:48 PST
Created attachment 125995 [details] Patch
Adam Barth
Comment 2 2012-02-07 21:31:07 PST
Comment on attachment 125995 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125995&action=review > Source/WebCore/bindings/scripts/test/TestOverridingNameGetter.idl:32 > - HasOverridingNameGetter > + CustomNamedGetter Should we change the name of this test file since it refers to the old attribute name?
Kentaro Hara
Comment 3 2012-02-07 21:41:25 PST
Created attachment 125997 [details] patch for commit
Kentaro Hara
Comment 4 2012-02-07 21:48:05 PST
Committed r107039: <http://trac.webkit.org/changeset/107039>
Kentaro Hara
Comment 5 2012-02-07 21:49:29 PST
Comment on attachment 125995 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125995&action=review >> Source/WebCore/bindings/scripts/test/TestOverridingNameGetter.idl:32 >> + CustomNamedGetter > > Should we change the name of this test file since it refers to the old attribute name? Nice catch. Renamed the file to TestCustomNamedGetter.idl, and committed manually (to avoid style check errors).
Note You need to log in before you can comment on or make changes to this bug.