Bug 78076 - Rename [HasOverridingNameGetter] attribute to [CustomNamedGetter] attribute
Summary: Rename [HasOverridingNameGetter] attribute to [CustomNamedGetter] attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 77393
  Show dependency treegraph
 
Reported: 2012-02-07 21:26 PST by Kentaro Hara
Modified: 2012-02-07 21:49 PST (History)
6 users (show)

See Also:


Attachments
Patch (15.47 KB, patch)
2012-02-07 21:29 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
patch for commit (126.72 KB, patch)
2012-02-07 21:41 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-07 21:26:31 PST
We can rename the [HasOverridingNameGetter] attribute to the [CustomNamedGetter] attribute, for naming consistency with [CustomNamedSetter].
Comment 1 Kentaro Hara 2012-02-07 21:29:48 PST
Created attachment 125995 [details]
Patch
Comment 2 Adam Barth 2012-02-07 21:31:07 PST
Comment on attachment 125995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125995&action=review

> Source/WebCore/bindings/scripts/test/TestOverridingNameGetter.idl:32
> -        HasOverridingNameGetter
> +        CustomNamedGetter

Should we change the name of this test file since it refers to the old attribute name?
Comment 3 Kentaro Hara 2012-02-07 21:41:25 PST
Created attachment 125997 [details]
patch for commit
Comment 4 Kentaro Hara 2012-02-07 21:48:05 PST
Committed r107039: <http://trac.webkit.org/changeset/107039>
Comment 5 Kentaro Hara 2012-02-07 21:49:29 PST
Comment on attachment 125995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125995&action=review

>> Source/WebCore/bindings/scripts/test/TestOverridingNameGetter.idl:32
>> +        CustomNamedGetter
> 
> Should we change the name of this test file since it refers to the old attribute name?

Nice catch. Renamed the file to TestCustomNamedGetter.idl, and committed manually (to avoid style check errors).