Bug 78064 – Web Inspector: avoid making a window for the Inspector when docked

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Timothy Hatcher]

Right now WebKit2 always makes a window even if the Inspector is docked. We should not make a window in that case and destroy the window when docked.

[Timothy Hatcher]

Created attachment 125972 [details]
Proposed Change

[Brian Weinstein]

Comment on attachment 125972 [details]
Proposed Change

View in context: https://bugs.webkit.org/attachment.cgi?id=125972&action=review

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:252
> +    }

Can this code be shared with the code in platformDidClose?

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:267
> +    [m_inspectorView.get() setHidden:NO];

How would it have been detached if it was hidden? I don't see how the undock button could have been pressed in this case.

[Timothy Hatcher]

(In reply to comment #2)
> (From update of attachment 125972 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=125972&action=review
> 
> > Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:252
> > +    }
> 
> Can this code be shared with the code in platformDidClose?

It could, but it didn't see worth adding more plaform specific member functions.

> 
> > Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:267
> > +    [m_inspectorView.get() setHidden:NO];
> 
> How would it have been detached if it was hidden? I don't see how the undock button could have been pressed in this case.

I was just being cautious. But you are right, there is no way to currently cause it.

[Timothy Hatcher]

Fixed in r107028.