Bug 78061 - Plumb through webGLErrorsToConsoleEnable in WebSettings
Summary: Plumb through webGLErrorsToConsoleEnable in WebSettings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Gregg Tavares
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-07 17:37 PST by Gregg Tavares
Modified: 2012-02-07 21:34 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.93 KB, patch)
2012-02-07 17:38 PST, Gregg Tavares
no flags Details | Formatted Diff | Diff
Patch (2.93 KB, patch)
2012-02-07 18:16 PST, Gregg Tavares
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gregg Tavares 2012-02-07 17:37:19 PST
Plum through webGLErrorsToConsoleEnable in WebSettings
Comment 1 Gregg Tavares 2012-02-07 17:38:19 PST
Created attachment 125966 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-07 17:42:47 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 3 Kenneth Russell 2012-02-07 18:11:17 PST
Comment on attachment 125966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125966&action=review

Looks fine to me. I can't imagine this being contentious and fishd's on vacation so I'm r+'ing it.

> Source/WebKit/chromium/ChangeLog:3
> +        Plum through webGLErrorsToConsoleEnable in WebSettings

Minor nit: plum -> plumb everywhere.
Comment 4 Gregg Tavares 2012-02-07 18:16:11 PST
Created attachment 125973 [details]
Patch
Comment 5 Kenneth Russell 2012-02-07 18:17:32 PST
Comment on attachment 125973 [details]
Patch

Looks good. r=me again
Comment 6 WebKit Review Bot 2012-02-07 21:34:25 PST
Comment on attachment 125973 [details]
Patch

Clearing flags on attachment: 125973

Committed r107037: <http://trac.webkit.org/changeset/107037>
Comment 7 WebKit Review Bot 2012-02-07 21:34:29 PST
All reviewed patches have been landed.  Closing bug.