Add keyframes to LayoutTests/media/content/test.ogv to hasten test completion & avoid timeouts.
Created attachment 125959 [details] Patch
note rebaselines may be needed for pixel tests (as the transcoding is likely to be slightly different from the original from 2 years ago).
Eric: would you mind reviewing/sanity-checking?
Comment on attachment 125959 [details] Patch Seems like a very sensible solution, rs=me.
Comment on attachment 125959 [details] Patch Rejecting attachment 125959 [details] from commit-queue. New failing tests: media/video-aspect-ratio.html media/track/track-cue-rendering.html compositing/direct-image-compositing.html media/video-canvas-alpha.html media/video-currentTime-set.html http/tests/inspector/inspect-element.html fast/frames/lots-of-objects.html media/controls-without-preload.html media/controls-after-reload.html http/tests/media/remove-while-loading.html http/tests/security/contentSecurityPolicy/media-src-allowed.html media/controls-styling.html media/media-controls-invalid-url.html media/video-layer-crash.html accessibility/aria-describedby-on-input.html media/track/track-cues-seeking.html media/controls-strict.html media/controls-drag-timebar.html media/video-display-toggle.html media/media-controller-playback.html media/video-duration-known-after-eos.html media/video-currentTime-delay.html Full output: http://queues.webkit.org/results/11487149
Created attachment 126354 [details] Patch
(In reply to comment #6) > Created an attachment (id=126354) [details] > Patch This patch addresses all timeouts (by avoiding having a metadata block at the back of the file, and by making keyframe interval match the source .mp4 as much as possible). Image rebaselines will still be necessary (for human-eye undiscernable diffs).
Comment on attachment 126354 [details] Patch Attachment 126354 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11473385 New failing tests: media/controls-strict.html media/video-volume-slider.html media/controls-styling.html media/video-display-toggle.html media/video-aspect-ratio.html media/video-zoom-controls.html media/video-zoom.html media/video-transformed.html media/controls-without-preload.html media/video-canvas-alpha.html media/video-layer-crash.html media/video-playing-and-pause.html media/controls-after-reload.html
Comment on attachment 126354 [details] Patch Rejecting attachment 126354 [details] from commit-queue. fischman@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Comment on attachment 126354 [details] Patch Marking cq+ so Ami can harvest and land updated pixel results for the newly compressed video.
Comment on attachment 126354 [details] Patch Rejecting attachment 126354 [details] from commit-queue. New failing tests: media/controls-strict.html media/video-volume-slider.html media/controls-styling.html media/video-display-toggle.html media/video-aspect-ratio.html media/video-zoom-controls.html media/video-zoom.html media/video-transformed.html media/controls-without-preload.html media/video-canvas-alpha.html media/video-layer-crash.html media/video-playing-and-pause.html media/controls-after-reload.html Full output: http://queues.webkit.org/results/11473529
Created attachment 126543 [details] Patch
Attachment 126543 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/medi..." exit_code: 1 LayoutTests/platform/chromium/test_expectations.txt:4026: More specific entry on line 2674 overrides line 4026 media/video-canvas-alpha.html [test/expectations] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 126575 [details] Patch
Comment on attachment 126575 [details] Patch Clearing flags on attachment: 126575 Committed r107452: <http://trac.webkit.org/changeset/107452>
All reviewed patches have been landed. Closing bug.