Bug 78057 - Fix the caculation of preDelayFrames in DynamicsCompressorKernel
Summary: Fix the caculation of preDelayFrames in DynamicsCompressorKernel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raymond
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-07 16:51 PST by Raymond
Modified: 2012-02-08 20:34 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2012-02-07 16:58 PST, Raymond
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raymond 2012-02-07 16:51:01 PST
Fix the caculation of preDelayFrames in DynamicsCompressorKernel
Comment 1 Raymond 2012-02-07 16:58:15 PST
Created attachment 125957 [details]
Patch
Comment 2 Raymond 2012-02-07 17:04:00 PST
Hi Chris

Without this patch, the DynamicsCompressorNode actually don't have any predelay applied for the compressor since the preDelayFrames will always be 0. Please help to take a review ;)
Comment 3 Raymond 2012-02-07 17:06:55 PST
(In reply to comment #2)
> Hi Chris
> 
> Without this patch, the DynamicsCompressorNode actually don't have any predelay applied for the compressor since the preDelayFrames will always be 0. Please help to take a review ;)

oh, though preDelayFrames will always be 0, due to the fact that the read is done before write, the actual preDelayFrame applied is 1024 not 0
Comment 4 Chris Rogers 2012-02-08 19:01:05 PST
Comment on attachment 125957 [details]
Patch

Wow - good catch!  That was really a bad one...
Comment 5 WebKit Review Bot 2012-02-08 20:34:54 PST
Comment on attachment 125957 [details]
Patch

Clearing flags on attachment: 125957

Committed r107172: <http://trac.webkit.org/changeset/107172>
Comment 6 WebKit Review Bot 2012-02-08 20:34:58 PST
All reviewed patches have been landed.  Closing bug.