Bug 78049 - [BlackBerry] Upstream BlackBerry WebCoreSupport FrameNetworkingContextBlackBerry and IconDatabaseClientBlackBerry classes
Summary: [BlackBerry] Upstream BlackBerry WebCoreSupport FrameNetworkingContextBlackBe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jacky Jiang
URL:
Keywords:
Depends on:
Blocks: 73144
  Show dependency tree / graph
 
Reported: 2012-02-07 15:10 PST by Jacky Jiang
Modified: 2012-02-09 12:38 PST (History)
5 users (show)

See Also:

Attachments
Patch (9.19 KB, patch)
2012-02-07 15:47 PST, Jacky Jiang 		no flags Details | Formatted Diff | Diff
Patch (9.19 KB, patch)
2012-02-08 16:09 PST, Jacky Jiang 		no flags Details | Formatted Diff | Diff
Patch (9.19 KB, patch)
2012-02-08 16:17 PST, Jacky Jiang 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacky Jiang 2012-02-07 15:10:38 PST 
Upstream BlackBerry WebCoreSupport FrameNetworkingContextBlackBerry and IconDatabaseClientBlackBerry classes.
Comment 1 Jacky Jiang 2012-02-07 15:47:03 PST 
Created attachment 125946 [details]
Patch
Comment 2 Rob Buis 2012-02-07 15:52:40 PST 
Comment on attachment 125946 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125946&action=review

Some small nits.

> Source/WebKit/blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.cpp:32
> +        instance = new IconDatabaseClientBlackBerry();

Can you use DEFINE_STATIC_LOCAL?

> Source/WebKit/blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.cpp:60
> +    return (m_initState == InitializeSucceeded);

No need for parentheses.

> Source/WebKit/blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.h:40
> +public:

Better move the public section up above the private, this is the standard.
Comment 3 Jacky Jiang 2012-02-08 16:09:13 PST 
Created attachment 126178 [details]
Patch

Update the patch except the DEFINE_STATIC_LOCAL which doesn't seem to work well.
Comment 4 Jacky Jiang 2012-02-08 16:11:55 PST 
Comment on attachment 126178 [details]
Patch

Typo in commit log, will update.
Comment 5 Jacky Jiang 2012-02-08 16:17:29 PST 
Created attachment 126180 [details]
Patch
Comment 6 Rob Buis 2012-02-08 18:05:37 PST 
Comment on attachment 126180 [details]
Patch

Looks good.
Comment 7 WebKit Review Bot 2012-02-08 23:02:20 PST 
Comment on attachment 126180 [details]
Patch

Clearing flags on attachment: 126180

Committed r107183: <http://trac.webkit.org/changeset/107183>
Comment 8 WebKit Review Bot 2012-02-08 23:02:34 PST 
All reviewed patches have been landed.  Closing bug.