Bug 78045 - Crash on http://www.rickshawbags.com/
Summary: Crash on http://www.rickshawbags.com/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL: http://www.rickshawbags.com/customize...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-02-07 14:51 PST by Gavin Barraclough
Modified: 2012-02-07 15:46 PST (History)
0 users

See Also:

Attachments
Fix (1.82 KB, patch)
2012-02-07 14:56 PST, Gavin Barraclough 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2012-02-07 14:51:41 PST 
This is a bug introduced by https://bugs.webkit.org/show_bug.cgi?id=71933, isVariableObject() checks were excluding StaticScopeObjects, this patch inadvertently changed them to be included.
Comment 1 Gavin Barraclough 2012-02-07 14:53:06 PST 
<rdar://problem/10697118>
Comment 2 Gavin Barraclough 2012-02-07 14:56:58 PST 
Created attachment 125938 [details]
Fix
Comment 3 Darin Adler 2012-02-07 15:13:15 PST 
Comment on attachment 125938 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=125938&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        Problem URL is: http://www.rickshawbags.com/customize/custom-bag#!thl=rickshaw/bag()

Can we make an automated regression test out of this?
Comment 4 Gavin Barraclough 2012-02-07 15:46:19 PST 
(In reply to comment #3)
> Can we make an automated regression test out of this?

Good question – I don't yet know.  This patch just reverts an undesired change in behavior, I'm still investigating exactly why this change resulted in the bug that it did.

Fixed in r106999.