Bug 7803 - Various (some hackish) improvements to Win32 support
Summary: Various (some hackish) improvements to Win32 support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: PC Windows XP
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-16 05:13 PST by Eric Seidel (no email)
Modified: 2006-03-16 16:11 PST (History)
0 users

See Also:


Attachments
First cut at a patch containing these varied changes. (96.35 KB, patch)
2006-03-16 05:15 PST, Eric Seidel (no email)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2006-03-16 05:13:50 PST
I'm posting this patch not because I feel that it's necessarily ready to land, but rather that I think it's large enough and covers enough diverse areas that I should talk some of these pieces out with others interested in win32 support.

This includes:
- partial key event support (likely sending incorrect keychars)
- partial selection support
- partial focus ring support (not rounded, not right color or pattern)

I also fixed the build in a couple ways, and moved khtml/editing to editing in the project file.
I fixed sending of scroll and resize events as well as handling view focus.

With this patch applied you can interact (but not type into) a contenteditable div, watch a caret blink, make selections on arbitrary text and images on any page, and see focus rings draw around highlighted controls.

The goal of these hacks are to get enough things to better understand what broken in the current code.  The FontWin code you see in this patch is obviously not something we could ship (but in writing it not only did I learn more about our font rendering APIs and hopefully have enabled myself and others to discover other engine bugs and further parallelize the work).
Comment 1 Eric Seidel (no email) 2006-03-16 05:15:06 PST
Created attachment 7112 [details]
First cut at a patch containing these varied changes.
Comment 2 Darin Adler 2006-03-16 08:43:27 PST
Comment on attachment 7112 [details]
First cut at a patch containing these varied changes.

+    return (float)runSize.width();

I'm surprised you need that cast.

+using namespace WebCore;
+
 #include "JSCanvasRenderingContext2DBaseTable.cpp"

I think that "using namespace" should go after the JSCanvasRenderingContext2DBaseTable.cpp include.

Looks fine, r=me.
Comment 3 Eric Seidel (no email) 2006-03-16 13:39:29 PST
(In reply to comment #2)
> (From update of attachment 7112 [details] [edit])
> +    return (float)runSize.width();
> 
> I'm surprised you need that cast.

Fixed.

> +using namespace WebCore;
> +
>  #include "JSCanvasRenderingContext2DBaseTable.cpp"
> 
> I think that "using namespace" should go after the
> JSCanvasRenderingContext2DBaseTable.cpp include.

This is to hack around the Script not including "using namespace WebCore;" itself.