Bug 78017 - move warning about css values and render style constants closer to where it applies
Summary: move warning about css values and render style constants closer to where it a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-07 12:13 PST by Tony Chang
Modified: 2012-02-07 13:22 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.78 KB, patch)
2012-02-07 12:17 PST, Tony Chang 		no flags Details | Formatted Diff | Diff
patch2 (8.12 KB, patch)
2012-02-07 12:26 PST, Tony Chang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-02-07 12:13:50 PST 
move warning about css values and render style constants closer to where it applies
Comment 1 Tony Chang 2012-02-07 12:17:00 PST 
Created attachment 125897 [details]
Patch
Comment 2 Darin Adler 2012-02-07 12:21:38 PST 
Comment on attachment 125897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125897&action=review

> Source/WebCore/css/CSSValueKeywords.in:11
> +// The order here should match the order of the EBorderStyle enum in RenderStyleConstants.h.

s/should/must/
Comment 3 Tony Chang 2012-02-07 12:26:59 PST 
Created attachment 125899 [details]
patch2
Comment 4 WebKit Review Bot 2012-02-07 13:22:46 PST 
Comment on attachment 125899 [details]
patch2

Clearing flags on attachment: 125899

Committed r106980: <http://trac.webkit.org/changeset/106980>
Comment 5 WebKit Review Bot 2012-02-07 13:22:50 PST 
All reviewed patches have been landed.  Closing bug.