Bug 78013 - [chromium] Gracefully handle compositor initialization failure in single-threaded proxy
Summary: [chromium] Gracefully handle compositor initialization failure in single-thre...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
Depends on:
Reported: 2012-02-07 11:54 PST by James Robinson
Modified: 2012-02-07 13:51 PST (History)
5 users (show)

See Also:

Patch (4.99 KB, patch)
2012-02-07 11:55 PST, James Robinson
no flags Details | Formatted Diff | Diff
Patch (5.81 KB, patch)
2012-02-07 13:11 PST, James Robinson
kbr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-02-07 11:54:33 PST
[chromium] Gracefully handle compositor initialization failure in single-threaded proxy
Comment 1 James Robinson 2012-02-07 11:55:37 PST
Created attachment 125894 [details]
Comment 2 James Robinson 2012-02-07 13:11:24 PST
Created attachment 125908 [details]
Comment 3 James Robinson 2012-02-07 13:11:33 PST
Fixed the threaded case too
Comment 4 Kenneth Russell 2012-02-07 13:28:58 PST
Comment on attachment 125908 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=125908&action=review

Looks OK assuming it's been tested; one comment.

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h:187
> +    bool updateLayers();

Please document the semantics of the return value. Why do some of the early outs in updateLayers return true?
Comment 5 James Robinson 2012-02-07 13:51:21 PST
Committed r106986: <http://trac.webkit.org/changeset/106986>