Bug 78009 - [Qt] Fetch the visible rect from LayerTreeHost instead of keeping a copy in each layer.
Summary: [Qt] Fetch the visible rect from LayerTreeHost instead of keeping a copy in e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-07 11:39 PST by Jocelyn Turcotte
Modified: 2012-02-09 06:41 PST (History)
5 users (show)

See Also:

Attachments
Patch (8.30 KB, patch)
2012-02-07 11:41 PST, Jocelyn Turcotte 		noam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2012-02-07 11:39:30 PST 
[Qt] Fetch the visible rect from LayerTreeHost instead of keeping a copy in each layer.
Comment 1 Jocelyn Turcotte 2012-02-07 11:41:10 PST 
Created attachment 125888 [details]
Patch
Comment 2 Noam Rosenthal 2012-02-07 15:55:05 PST 
Comment on attachment 125888 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125888&action=review

LGTM with nitpicks

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:495
> +    if (m_mainBackingStore && m_mainBackingStore->contentsScale() != scale) {

<nitpick> can be nicer with an early return.

> Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp:431
> +    for (HashSet<WebCore::WebGraphicsLayer*>::iterator iter = m_registeredLayers.begin(); iter != end; ++iter) {

it instead of iter
Comment 3 Jocelyn Turcotte 2012-02-09 06:41:18 PST 
Committed r107237: <http://trac.webkit.org/changeset/107237>