Bug 77993 - [BlackBerry] Upstream BlackBerry WebCoreSupport DeviceOrientationClientBlackBerry and DeviceMotionClientBlackBerry classes
Summary: [BlackBerry] Upstream BlackBerry WebCoreSupport DeviceOrientationClientBlackB...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jacky Jiang
URL:
Keywords:
Depends on:
Blocks: 73144
  Show dependency treegraph
 
Reported: 2012-02-07 08:36 PST by Jacky Jiang
Modified: 2012-02-07 12:40 PST (History)
5 users (show)

See Also:


Attachments
Patch (11.58 KB, patch)
2012-02-07 09:08 PST, Jacky Jiang
no flags Details | Formatted Diff | Diff
Patch (11.70 KB, patch)
2012-02-07 11:50 PST, Jacky Jiang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jacky Jiang 2012-02-07 08:36:54 PST
Upstream BlackBerry WebCoreSupport DeviceOrientationClientBlackBerry and DeviceMotionClientBlackBerry classes.
Comment 1 Rob Buis 2012-02-07 08:56:03 PST
Assign to Jacky.
Comment 2 Jacky Jiang 2012-02-07 09:08:35 PST
Created attachment 125857 [details]
Patch
Comment 3 Rob Buis 2012-02-07 10:36:29 PST
Comment on attachment 125857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125857&action=review

I think this can be cleaned up a bit more.

> Source/WebKit/blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.cpp:24
> +#include "Page.h"

You don't need this include.

> Source/WebKit/blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.h:25
> +#include <BlackBerryPlatformDeviceMotionTracker.h>

You don't need this include, a forward class reference is enough.

> Source/WebKit/blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.cpp:23
> +#include "Page.h"

You don't need this include.

> Source/WebKit/blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.h:25
> +#include <BlackBerryPlatformDeviceOrientationTracker.h>

You don't need to include this, a forward reference should be ok.
Comment 4 Jacky Jiang 2012-02-07 11:50:04 PST
Created attachment 125890 [details]
Patch

Updated the patch based on Rob's comments.
Comment 5 Rob Buis 2012-02-07 11:59:04 PST
Comment on attachment 125890 [details]
Patch

LGTM.
Comment 6 WebKit Review Bot 2012-02-07 12:40:24 PST
Comment on attachment 125890 [details]
Patch

Clearing flags on attachment: 125890

Committed r106976: <http://trac.webkit.org/changeset/106976>
Comment 7 WebKit Review Bot 2012-02-07 12:40:30 PST
All reviewed patches have been landed.  Closing bug.