Bug 77980 - [GTK] Include gdk-pixbuf in the jhbuild modules
Summary: [GTK] Include gdk-pixbuf in the jhbuild modules
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mario Sanchez Prada
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2012-02-07 06:11 PST by Mario Sanchez Prada
Modified: 2012-02-07 07:22 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.85 KB, patch)
2012-02-07 06:14 PST, Mario Sanchez Prada
no flags Details | Formatted Diff | Diff
Patch (1.87 KB, patch)
2012-02-07 06:27 PST, Mario Sanchez Prada
no flags Details | Formatted Diff | Diff
Patch (1.87 KB, patch)
2012-02-07 07:00 PST, Mario Sanchez Prada
gns: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2012-02-07 06:11:47 PST
We need to add gdk-pixbuf to the jhbuild modules to avoid breaking things if building with a too recent version of gdk-pixbuf, which would fail to find symbols provided by the new GIO's GResource, not present until glib 2.31.16 (we include 2.31.2 in WKGTK's jhbuild modules).

We could raise glib up to 2.31.16, but this would cause even more trouble when trying to build libsoup (it will fail to link due to not finding g_module_open() while generating the introspection information) and so it seems more sensible to add gdk-pixbuf, instead.

I'm thinking of gdk-pixbuf 2.35.5 since that's what we have installed in the bots now.
Comment 1 Mario Sanchez Prada 2012-02-07 06:14:26 PST
Created attachment 125832 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2012-02-07 06:16:51 PST
Comment on attachment 125832 [details]
Patch

Attachment 125832 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11451001
Comment 3 Mario Sanchez Prada 2012-02-07 06:27:24 PST
Created attachment 125836 [details]
Patch
Comment 4 Gustavo Noronha (kov) 2012-02-07 06:30:36 PST
Comment on attachment 125836 [details]
Patch

Attachment 125836 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11440284
Comment 5 Mario Sanchez Prada 2012-02-07 07:00:15 PST
Created attachment 125840 [details]
Patch
Comment 6 Gustavo Noronha (kov) 2012-02-07 07:04:33 PST
Comment on attachment 125840 [details]
Patch

I've been wondering about our tarball usage, been thinking migrating all modules to git might be a good idea, but we can do all of them at once if we decide it's indeed a good idea =)
Comment 7 Mario Sanchez Prada 2012-02-07 07:22:16 PST
Committed r106936: <http://trac.webkit.org/changeset/106936>