Per http://www.w3.org/TR/notifications/ a simple text notification should have an iconURL. A patch is coming soon.
Created attachment 125828 [details] Patch Add an iconURL to WebNotification and add a public API to access it.
Comment on attachment 125828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125828&action=review I do not have reviewer status, but this otherwise looks good to me. > Source/WebKit2/UIProcess/API/C/WKNotification.cpp:50 > +WKStringRef WKNotificationCopyiconURL(WKNotificationRef notification) icon should be capitalized. > Source/WebKit2/UIProcess/API/C/WKNotification.h:39 > +WK_EXPORT WKStringRef WKNotificationCopyiconURL(WKNotificationRef notification); Ditto here.
(In reply to comment #2) > (From update of attachment 125828 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=125828&action=review > > I do not have reviewer status, but this otherwise looks good to me. > Thanks for reviewing :) > > Source/WebKit2/UIProcess/API/C/WKNotification.cpp:50 > > +WKStringRef WKNotificationCopyiconURL(WKNotificationRef notification) > > icon should be capitalized. Sorry, will fix it. > > > Source/WebKit2/UIProcess/API/C/WKNotification.h:39 > > +WK_EXPORT WKStringRef WKNotificationCopyiconURL(WKNotificationRef notification); > > Ditto here. Sorry, will fix it.
Created attachment 125870 [details] Patch. Fix case of IconURL.
Comment on attachment 125870 [details] Patch. Clearing flags on attachment: 125870 Committed r107068: <http://trac.webkit.org/changeset/107068>
All reviewed patches have been landed. Closing bug.