Bug 77968 - [WK2] Text notifications should have an iconURL
Summary: [WK2] Text notifications should have an iconURL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 77969
  Show dependency treegraph
 
Reported: 2012-02-07 04:56 PST by Yael
Modified: 2012-02-08 04:14 PST (History)
3 users (show)

See Also:


Attachments
Patch (10.86 KB, patch)
2012-02-07 05:54 PST, Yael
no flags Details | Formatted Diff | Diff
Patch. (10.86 KB, patch)
2012-02-07 10:13 PST, Yael
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2012-02-07 04:56:33 PST
Per http://www.w3.org/TR/notifications/ a simple text notification should have an iconURL.
A patch is coming soon.
Comment 1 Yael 2012-02-07 05:54:12 PST
Created attachment 125828 [details]
Patch

Add an iconURL to WebNotification and add a public API to access it.
Comment 2 Jon Lee 2012-02-07 10:01:28 PST
Comment on attachment 125828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125828&action=review

I do not have reviewer status, but this otherwise looks good to me.

> Source/WebKit2/UIProcess/API/C/WKNotification.cpp:50
> +WKStringRef WKNotificationCopyiconURL(WKNotificationRef notification)

icon should be capitalized.

> Source/WebKit2/UIProcess/API/C/WKNotification.h:39
> +WK_EXPORT WKStringRef WKNotificationCopyiconURL(WKNotificationRef notification);

Ditto here.
Comment 3 Yael 2012-02-07 10:03:33 PST
(In reply to comment #2)
> (From update of attachment 125828 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=125828&action=review
> 
> I do not have reviewer status, but this otherwise looks good to me.
> 
Thanks for reviewing :)

> > Source/WebKit2/UIProcess/API/C/WKNotification.cpp:50
> > +WKStringRef WKNotificationCopyiconURL(WKNotificationRef notification)
> 
> icon should be capitalized.
Sorry, will fix it.
> 
> > Source/WebKit2/UIProcess/API/C/WKNotification.h:39
> > +WK_EXPORT WKStringRef WKNotificationCopyiconURL(WKNotificationRef notification);
> 
> Ditto here.
Sorry, will fix it.
Comment 4 Yael 2012-02-07 10:13:48 PST
Created attachment 125870 [details]
Patch.

Fix case of IconURL.
Comment 5 WebKit Review Bot 2012-02-08 04:14:08 PST
Comment on attachment 125870 [details]
Patch.

Clearing flags on attachment: 125870

Committed r107068: <http://trac.webkit.org/changeset/107068>
Comment 6 WebKit Review Bot 2012-02-08 04:14:13 PST
All reviewed patches have been landed.  Closing bug.