Bug 77942 – GTK & QT Rebaseline after r106912

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Kaustubh Atrawalkar]

Rebaselining the tests after r106912.

[Kaustubh Atrawalkar]

Created attachment 125778 [details]
Patch

Re-committing the changes from http://trac.webkit.org/changeset/106105 & http://trac.webkit.org/changeset/105493

[Kaustubh Atrawalkar]

(In reply to comment #1)
> Created an attachment (id=125778) [details]
> Patch
> 
> Re-committing the changes from http://trac.webkit.org/changeset/106105 & http://trac.webkit.org/changeset/105493

GTK Rebaseline as per - http://trac.webkit.org/changeset/105520

[David Levin]

Comment on attachment 125778 [details]
Patch

These should have been in your patch :(

[Kaustubh Atrawalkar]

(In reply to comment #3)
> (From update of attachment 125778 [details])
> These should have been in your patch :(
I know :( Ossy (Csaba Osztrogonac) had asked me to add in patch but I missed those. My mistake. So added immediately.

[Csaba Osztrogonác]

Comment on attachment 125778 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125778&action=review

Is there a bug report to fix these expected failures?

> LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt:336
> +FAIL webkitURL.toString() should be [object webkitURLConstructor]. Was [object DOMURLConstructor].

Is this fail expected?

> LayoutTests/platform/qt/fast/js/global-constructors-expected.txt:318
> +FAIL webkitURL.toString() should be [object webkitURLConstructor]. Was [object DOMURLConstructor].

Is this fail expected?

[Kaustubh Atrawalkar]

(In reply to comment #5)
> (From update of attachment 125778 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=125778&action=review
> 
> Is there a bug report to fix these expected failures?
> 
> > LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt:336
> > +FAIL webkitURL.toString() should be [object webkitURLConstructor]. Was [object DOMURLConstructor].
> 
> Is this fail expected?
> 
> > LayoutTests/platform/qt/fast/js/global-constructors-expected.txt:318
> > +FAIL webkitURL.toString() should be [object webkitURLConstructor]. Was [object DOMURLConstructor].
> 
> Is this fail expected?

Yes these are expected. need to fix the naming conventions for DOMURL. Currently there is no bug report filed. But will do it.

[WebKit Review Bot]

Comment on attachment 125778 [details]
Patch

Clearing flags on attachment: 125778

Committed r106915: <http://trac.webkit.org/changeset/106915>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

It was rolled out (http://trac.webkit.org/changeset/106922) because the original r106912 was rolled out too.

[Csaba Osztrogonác]

Otherwise please don't open new bug report for rebaseline after rXXXXX,
but add it to the original bug.