Bug 77933 - [EFL] Use modifier keys to execute pre-rendering.
Summary: [EFL] Use modifier keys to execute pre-rendering.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-06 22:00 PST by JungJik Lee
Modified: 2012-02-19 11:30 PST (History)
6 users (show)

See Also:


Attachments
proposal patch (4.34 KB, patch)
2012-02-07 02:16 PST, JungJik Lee
no flags Details | Formatted Diff | Diff
patch_1 (4.32 KB, patch)
2012-02-08 06:55 PST, JungJik Lee
no flags Details | Formatted Diff | Diff
patch_2 (2.63 KB, patch)
2012-02-19 05:13 PST, JungJik Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JungJik Lee 2012-02-06 22:00:55 PST
I've changed the code to use modifier key to execute pre-rendering instead of using reserved function keys.
Because F10 fuction key is already reserved by system or ecore/efl, so eweblauncher can not catch the key event.
In addtion, we run out of function keys to map other features.
so that I remap the current pre-rendering function to shortcut keys by using modifier keys.
Comment 1 JungJik Lee 2012-02-07 02:16:17 PST
Created attachment 125792 [details]
proposal patch
Comment 2 KwangHyuk 2012-02-07 20:19:49 PST
Just a few idea is added.

> Tools/EWebLauncher/main.c:436
> +        modifierKey = modifierKey | ECORE_EVENT_MODIFIER_CTRL;

Why don't you use "modifierKey |= ECORE_EVENT_MODIFIER_CTRL;" ?

> Tools/EWebLauncher/main.c:565
> +    Evas_Event_Key_Up *ev = (Evas_Event_Key_Up*) event_info;

(Evas_Event_Key_Up*) ?
Comment 3 JungJik Lee 2012-02-08 03:38:37 PST
(In reply to comment #2)
> Just a few idea is added.
> 
> > Tools/EWebLauncher/main.c:436
> > +        modifierKey = modifierKey | ECORE_EVENT_MODIFIER_CTRL;
> 
> Why don't you use "modifierKey |= ECORE_EVENT_MODIFIER_CTRL;" ?
> 
i'll fix it.
> > Tools/EWebLauncher/main.c:565
> > +    Evas_Event_Key_Up *ev = (Evas_Event_Key_Up*) event_info;
> 
> (Evas_Event_Key_Up*) ?
do you point to type casting, *'s position or Evas_Event_Key_Up itself?
Eweblauncher is still C file.
Comment 4 JungJik Lee 2012-02-08 06:55:26 PST
Created attachment 126077 [details]
patch_1
Comment 5 KwangHyuk 2012-02-08 16:51:01 PST
LGTM.
Comment 6 Chang Shu 2012-02-17 02:24:32 PST
Comment on attachment 126077 [details]
patch_1

View in context: https://bugs.webkit.org/attachment.cgi?id=126077&action=review

> Tools/EWebLauncher/main.c:436
> +    if (!strcmp(ev->key, "Control_L"))
> +        modifierKey |= ECORE_EVENT_MODIFIER_CTRL;

Why isn't this a part of the if-elseif block below?
In another question, a key event usually comes in with modifier status. That is to say, when you have ev->key=="g", you check if ev->modifier==CTRL-L(note this is my fake code). Isn't it the case in EFL? Using a static modiferkey variable seems hacky.
Comment 7 JungJik Lee 2012-02-19 05:13:03 PST
Created attachment 127733 [details]
patch_2

Thanks your comment and as your comment, I found the simple way to use modifier key.
Comment 8 Chang Shu 2012-02-19 10:15:44 PST
Comment on attachment 127733 [details]
patch_2

Good!
Comment 9 WebKit Review Bot 2012-02-19 11:29:57 PST
Comment on attachment 127733 [details]
patch_2

Clearing flags on attachment: 127733

Committed r108192: <http://trac.webkit.org/changeset/108192>
Comment 10 WebKit Review Bot 2012-02-19 11:30:02 PST
All reviewed patches have been landed.  Closing bug.