WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 77929
Stop calling Element::ensureShadowRoot() if it's used in construction phase.
https://bugs.webkit.org/show_bug.cgi?id=77929
Summary
Stop calling Element::ensureShadowRoot() if it's used in construction phase.
Shinya Kawanaka
Reported
2012-02-06 20:29:38 PST
Some elements calls ensureShadowRoot() dynamically, but the other elements calls ensureShadowRoot() when they are constructing. These calls can be easily removed, so let's remove them first.
Attachments
Patch
(11.14 KB, patch)
2012-02-06 21:11 PST
,
Shinya Kawanaka
no flags
Details
Formatted Diff
Diff
Patch
(6.72 KB, patch)
2012-02-06 21:42 PST
,
Shinya Kawanaka
no flags
Details
Formatted Diff
Diff
Patch
(6.83 KB, patch)
2012-02-07 23:14 PST
,
Shinya Kawanaka
no flags
Details
Formatted Diff
Diff
Patch
(7.44 KB, patch)
2012-02-08 18:47 PST
,
Shinya Kawanaka
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1
2012-02-06 21:11:03 PST
Created
attachment 125761
[details]
Patch
Hajime Morrita
Comment 2
2012-02-06 21:35:36 PST
Comment on
attachment 125761
[details]
Patch Basically OK. Could you split symbol removal to another patch?
Shinya Kawanaka
Comment 3
2012-02-06 21:42:35 PST
Created
attachment 125763
[details]
Patch
WebKit Review Bot
Comment 4
2012-02-06 23:25:21 PST
Comment on
attachment 125763
[details]
Patch Clearing flags on attachment: 125763 Committed
r106909
: <
http://trac.webkit.org/changeset/106909
>
WebKit Review Bot
Comment 5
2012-02-06 23:25:26 PST
All reviewed patches have been landed. Closing bug.
Shinya Kawanaka
Comment 6
2012-02-07 18:18:01 PST
rolled out, so reopen.
Shinya Kawanaka
Comment 7
2012-02-07 23:14:19 PST
Created
attachment 126014
[details]
Patch
Shinya Kawanaka
Comment 8
2012-02-07 23:16:38 PST
We're not sure that patch caused chromium win release bot failure. I guess this patch doesn't, but I'm not sure. The previous export list patch caused it, maybe? So let's land it again and see the chromium bot again.
WebKit Review Bot
Comment 9
2012-02-07 23:29:29 PST
Comment on
attachment 126014
[details]
Patch Rejecting
attachment 126014
[details]
from commit-queue.
shinyak@chromium.org
does not have committer permissions according to
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py
. - If you do not have committer rights please read
http://webkit.org/coding/contributing.html
for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Hajime Morrita
Comment 10
2012-02-08 00:21:18 PST
Comment on
attachment 126014
[details]
Patch Let's see what happen...
WebKit Review Bot
Comment 11
2012-02-08 00:57:24 PST
Comment on
attachment 126014
[details]
Patch Clearing flags on attachment: 126014 Committed
r107050
: <
http://trac.webkit.org/changeset/107050
>
WebKit Review Bot
Comment 12
2012-02-08 00:57:29 PST
All reviewed patches have been landed. Closing bug.
Shinya Kawanaka
Comment 13
2012-02-08 18:21:14 PST
I found a bug that ShadowRoot checks ExceptionCode, but it was not initialized. We shouldn't assume ExceptionCode is initialized...
Shinya Kawanaka
Comment 14
2012-02-08 18:24:27 PST
rolled out again, reopen.
Shinya Kawanaka
Comment 15
2012-02-08 18:47:42 PST
Created
attachment 126216
[details]
Patch
Hajime Morrita
Comment 16
2012-02-08 21:47:07 PST
Comment on
attachment 126216
[details]
Patch Clearing flags on attachment: 126216 Committed
r107178
: <
http://trac.webkit.org/changeset/107178
>
Hajime Morrita
Comment 17
2012-02-08 21:47:17 PST
All reviewed patches have been landed. Closing bug.
Shinya Kawanaka
Comment 18
2012-02-08 21:54:56 PST
Let's seeing
http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29?numbuilds=50
for a while.
Shinya Kawanaka
Comment 19
2012-02-08 22:17:31 PST
http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/23566
OK. webkit-unit-tests passed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug