Bug 77924 – Dashboard on perf-o-matic should be sorted

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Website

[Ryosuke Niwa]

Right now, the tests on the dashboard show up on random order( depends on how Python generates JSON, which in turn depends on how they order hashed strings). We should sort them nicely so that people don't have to keep looking for the tests.

[Ryosuke Niwa]

Created attachment 125750 [details]
Fixes the bug

[Tony Chang]

Comment on attachment 125750 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=125750&action=review

> Websites/webkit-perf.appspot.com/js/config.js:84
> +        for (test in testToId)
> +            tests.push(test);

Can you use Object.keys(testToId)?

> Websites/webkit-perf.appspot.com/js/config.js:88
> +        for (var i = 0; i < tests.length; i++)
> +            sortedTestToId[tests[i]] = testToId[tests[i]];
> +        dashboardManifest['testToId'] = sortedTestToId;

This is OK, but it would be more efficient to sort when you use dashboardManifest['testToId'].  I guess that involves changing perfomatic code.

[Ryosuke Niwa]

Comment on attachment 125750 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=125750&action=review

>> Websites/webkit-perf.appspot.com/js/config.js:84
>> +            tests.push(test);
> 
> Can you use Object.keys(testToId)?

Sure.

>> Websites/webkit-perf.appspot.com/js/config.js:88
>> +        dashboardManifest['testToId'] = sortedTestToId;
> 
> This is OK, but it would be more efficient to sort when you use dashboardManifest['testToId'].  I guess that involves changing perfomatic code.

Right. And we can't sort tests on Mozilla's version (the order is hard-coded there).

[Ryosuke Niwa]

Fixed in http://trac.webkit.org/changeset/106960.