There are a handfull of functions and variables that should be switched to LayoutUnits from integers.
Created attachment 125732 [details] Patch
Comment on attachment 125732 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125732&action=review > Source/WebCore/rendering/ColumnInfo.h:76 > + LayoutUnit forcedBreaks() const { return m_forcedBreaks; } Is this a count?
Created attachment 125869 [details] Patch
(In reply to comment #2) > (From update of attachment 125732 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=125732&action=review > > > Source/WebCore/rendering/ColumnInfo.h:76 > > + LayoutUnit forcedBreaks() const { return m_forcedBreaks; } > > Is this a count? Good catch! I had the functions swapped.
Comment on attachment 125869 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125869&action=review > Source/WebCore/ChangeLog:8 > + Updating usage of LayoutUnits in ColumnInfo and RenderFrameSet. You should clarify in your Changelog (or code) why these are different from table columns. All these changes are fine, but I think you should spend a bit more effort on the *why* explanations. :)
Comment on attachment 125869 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125869&action=review >> Source/WebCore/ChangeLog:8 >> + Updating usage of LayoutUnits in ColumnInfo and RenderFrameSet. > > You should clarify in your Changelog (or code) why these are different from table columns. > > All these changes are fine, but I think you should spend a bit more effort on the *why* explanations. :) Will do. Thanks for the review!
Committed r107009: <http://trac.webkit.org/changeset/107009>
Comment on attachment 125869 [details] Patch Clearing Flags