Bug 77914 - Update LayoutUnit usage in ColumnInfo and RenderFrameSet
Summary: Update LayoutUnit usage in ColumnInfo and RenderFrameSet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency treegraph
 
Reported: 2012-02-06 16:58 PST by Levi Weintraub
Modified: 2012-02-07 16:56 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.77 KB, patch)
2012-02-06 17:03 PST, Levi Weintraub
no flags Details | Formatted Diff | Diff
Patch (3.83 KB, patch)
2012-02-07 10:13 PST, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-02-06 16:58:43 PST
There are a handfull of functions and variables that should be switched to LayoutUnits from integers.
Comment 1 Levi Weintraub 2012-02-06 17:03:19 PST
Created attachment 125732 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-06 18:19:40 PST
Comment on attachment 125732 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125732&action=review

> Source/WebCore/rendering/ColumnInfo.h:76
> +    LayoutUnit forcedBreaks() const { return m_forcedBreaks; }

Is this a count?
Comment 3 Levi Weintraub 2012-02-07 10:13:31 PST
Created attachment 125869 [details]
Patch
Comment 4 Levi Weintraub 2012-02-07 10:14:50 PST
(In reply to comment #2)
> (From update of attachment 125732 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=125732&action=review
> 
> > Source/WebCore/rendering/ColumnInfo.h:76
> > +    LayoutUnit forcedBreaks() const { return m_forcedBreaks; }
> 
> Is this a count?

Good catch! I had the functions swapped.
Comment 5 Eric Seidel (no email) 2012-02-07 14:16:04 PST
Comment on attachment 125869 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125869&action=review

> Source/WebCore/ChangeLog:8
> +        Updating usage of LayoutUnits in ColumnInfo and RenderFrameSet.

You should clarify in your Changelog (or code) why these are different from table columns.

All these changes are fine, but I think you should spend a bit more effort on the *why* explanations. :)
Comment 6 Levi Weintraub 2012-02-07 14:17:03 PST
Comment on attachment 125869 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125869&action=review

>> Source/WebCore/ChangeLog:8
>> +        Updating usage of LayoutUnits in ColumnInfo and RenderFrameSet.
> 
> You should clarify in your Changelog (or code) why these are different from table columns.
> 
> All these changes are fine, but I think you should spend a bit more effort on the *why* explanations. :)

Will do. Thanks for the review!
Comment 7 Levi Weintraub 2012-02-07 16:52:44 PST
Committed r107009: <http://trac.webkit.org/changeset/107009>
Comment 8 Levi Weintraub 2012-02-07 16:56:27 PST
Comment on attachment 125869 [details]
Patch

Clearing Flags