I expect layoutBlock never gets called for floats.
Created attachment 125953 [details] Patch
Comment on attachment 125953 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125953&action=review > LayoutTests/css3/flexbox/floated-flexbox-expected.txt:2 > +FAIL: > +Expected 130 for width, but got 110. This fails because of not implementing computePreferredLogicalWidth as per https://bugs.webkit.org/show_bug.cgi?id=76867. This patch fixes the expected height to be 30 instead of 50 since the flex-items no longer wrap now that we properly treat the parent as a flexbox.
Comment on attachment 125953 [details] Patch Attachment 125953 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11460165 New failing tests: fast/lists/001-vertical.html fast/block/float/016.html fast/lists/001.html fast/lists/positioned-count-crash.html
Comment on attachment 125953 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125953&action=review > Source/WebCore/css/CSSStyleSelector.cpp:1730 > +static void adjustDisplay(RenderStyle* style, Element *e, bool strictParsing) Element* element, not Element *e
Created attachment 125984 [details] Patch
Restructured after discussion with Eric.
Comment on attachment 125984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125984&action=review > Source/WebCore/css/CSSStyleSelector.cpp:1771 > + case NONE: // FIXME: Should NONE really map to BLOCK here? I'm not sure thsi FIXME makes sense anymore, but the code seems fine.
Committed r107112: <http://trac.webkit.org/changeset/107112>