Bug 77908 - http/tests/security/xssAuditor/cookie-injection.html is flaky
Summary: http/tests/security/xssAuditor/cookie-injection.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-06 15:30 PST by Adam Barth
Modified: 2012-02-06 22:33 PST (History)
2 users (show)

See Also:


Attachments
Patch (3.19 KB, patch)
2012-02-06 15:33 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (4.02 KB, patch)
2012-02-06 16:36 PST, Adam Barth
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-02-06 15:30:51 PST
http/tests/security/xssAuditor/cookie-injection.html is flaky
Comment 1 Adam Barth 2012-02-06 15:33:23 PST
Created attachment 125717 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-06 16:28:05 PST
Comment on attachment 125717 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125717&action=review

The change looks fine now that I understand it.

> LayoutTests/http/tests/security/xssAuditor/resources/echo-intertag.pl:51
> +    print "<script>if (/testcookie/.exec(document.cookie)) { alert('FAIL: ' + document.cookie); document.cookie = 'testcookie=remove; max-age=-1'; }</script>\n";

I think you want .test() instead of .exec(): https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/RegExp/test

> LayoutTests/http/tests/security/xssAuditor/resources/echo-intertag.pl:52
>  }

I think we should also alert PASS to make it clearer that it passed.
Comment 3 Adam Barth 2012-02-06 16:36:02 PST
Created attachment 125729 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-02-06 19:31:51 PST
Comment on attachment 125729 [details]
Patch for landing

Rejecting attachment 125729 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10594 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 10594.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11436116
Comment 5 Adam Barth 2012-02-06 22:33:45 PST
Committed r106906: <http://trac.webkit.org/changeset/106906>