Bug 77905 - Change baselinePosition and lineHeight to LayoutUnit
Summary: Change baselinePosition and lineHeight to LayoutUnit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency treegraph
 
Reported: 2012-02-06 15:07 PST by Emil A Eklund
Modified: 2012-02-06 20:26 PST (History)
6 users (show)

See Also:


Attachments
Patch (19.47 KB, patch)
2012-02-06 15:49 PST, Emil A Eklund
no flags Details | Formatted Diff | Diff
Patch (19.56 KB, patch)
2012-02-06 18:18 PST, Emil A Eklund
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-02-06 15:07:43 PST
Change baselinePosition and lineHeight to return LayoutUnit instead of int.
Comment 1 Emil A Eklund 2012-02-06 15:49:26 PST
Created attachment 125720 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-06 17:53:20 PST
Comment on attachment 125720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125720&action=review

> Source/WebCore/ChangeLog:9
> +        Change the virtual baselinePosition and lineHeight methods to use
> +        LayoutUnits in preparation for the switch over to subpixel layout.

It would be better to explain why these functions should be using these types in the Changelog.  You don't have to detail each one, but a setence like:

RenderTheme deals only with rendering objects, which will be positioned by LayoutUnit coordinates.

or something like that.
Comment 3 Emil A Eklund 2012-02-06 18:05:16 PST
> It would be better to explain why these functions should be using these types in the Changelog.  

Good point, I'll update the description to be more descriptive.
Comment 4 Emil A Eklund 2012-02-06 18:18:19 PST
Created attachment 125745 [details]
Patch
Comment 5 Emil A Eklund 2012-02-06 19:01:24 PST
Thanks!
Comment 6 WebKit Review Bot 2012-02-06 20:26:34 PST
Comment on attachment 125745 [details]
Patch

Clearing flags on attachment: 125745

Committed r106900: <http://trac.webkit.org/changeset/106900>
Comment 7 WebKit Review Bot 2012-02-06 20:26:40 PST
All reviewed patches have been landed.  Closing bug.