Change baselinePosition and lineHeight to return LayoutUnit instead of int.
Created attachment 125720 [details]
Comment on attachment 125720 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=125720&action=review
> + Change the virtual baselinePosition and lineHeight methods to use
> + LayoutUnits in preparation for the switch over to subpixel layout.
It would be better to explain why these functions should be using these types in the Changelog. You don't have to detail each one, but a setence like:
RenderTheme deals only with rendering objects, which will be positioned by LayoutUnit coordinates.
or something like that.
> It would be better to explain why these functions should be using these types in the Changelog.
Good point, I'll update the description to be more descriptive.
Created attachment 125745 [details]
Comment on attachment 125745 [details]
Clearing flags on attachment: 125745
Committed r106900: <http://trac.webkit.org/changeset/106900>
All reviewed patches have been landed. Closing bug.