Change baselinePosition and lineHeight to LayoutUnit

[Emil A Eklund]

Change baselinePosition and lineHeight to return LayoutUnit instead of int.

[Emil A Eklund]

Created attachment 125720 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 125720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125720&action=review

> Source/WebCore/ChangeLog:9
> +        Change the virtual baselinePosition and lineHeight methods to use
> +        LayoutUnits in preparation for the switch over to subpixel layout.

It would be better to explain why these functions should be using these types in the Changelog.  You don't have to detail each one, but a setence like:

RenderTheme deals only with rendering objects, which will be positioned by LayoutUnit coordinates.

or something like that.

[Emil A Eklund]

> It would be better to explain why these functions should be using these types in the Changelog.  

Good point, I'll update the description to be more descriptive.

[Emil A Eklund]

Created attachment 125745 [details]
Patch

[Emil A Eklund]

Thanks!

[WebKit Review Bot]

Comment on attachment 125745 [details]
Patch

Clearing flags on attachment: 125745

Committed r106900: <http://trac.webkit.org/changeset/106900>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.