Bug 77891 - Correct usage of LayoutUnits in dom, editing, page, accessibility, inspector, and loader
Summary: Correct usage of LayoutUnits in dom, editing, page, accessibility, inspector,...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on: 77920
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-02-06 11:56 PST by Levi Weintraub
Modified: 2012-02-06 17:55 PST (History)
8 users (show)

See Also:

Attachments
Patch (24.43 KB, patch)
2012-02-06 12:00 PST, Levi Weintraub 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-02-06 11:56:34 PST 
As we worked the bugs out of our sub-pixel positioning change on our branch, some usages of Layout* types were added, while others went back to integers. This brings trunk's usage in line with our branch.
Comment 1 Levi Weintraub 2012-02-06 12:00:56 PST 
Created attachment 125682 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-06 13:10:44 PST 
Do we have a document somewhere which describes the general usage guidelines for types in WebCore?  I want to know (at a high level) where we plan to use LayoutUnit vs. int vs. float vs. double vs. whatever.
Comment 3 Levi Weintraub 2012-02-06 14:19:01 PST 
(In reply to comment #2)
> Do we have a document somewhere which describes the general usage guidelines for types in WebCore?  I want to know (at a high level) where we plan to use LayoutUnit vs. int vs. float vs. double vs. whatever.

Feel free to ask for clarification and well add it to this doc: https://trac.webkit.org/wiki/LayoutUnit
Comment 4 Levi Weintraub 2012-02-06 15:55:36 PST 
Comment on attachment 125682 [details]
Patch

Thanks for the review!
Comment 5 WebKit Review Bot 2012-02-06 17:36:41 PST 
Comment on attachment 125682 [details]
Patch

Clearing flags on attachment: 125682

Committed r106884: <http://trac.webkit.org/changeset/106884>
Comment 6 WebKit Review Bot 2012-02-06 17:36:47 PST 
All reviewed patches have been landed.  Closing bug.