Bug 77890 - [GTK] Fix remaining errors in GTK+ WebKit2 API
Summary: [GTK] Fix remaining errors in GTK+ WebKit2 API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-06 11:54 PST by Martin Robinson
Modified: 2012-02-06 13:01 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.80 KB, patch)
2012-02-06 12:08 PST, Martin Robinson
no flags Details | Formatted Diff | Diff
Do not unskip WebKit1 tests (6.11 KB, patch)
2012-02-06 12:16 PST, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2012-02-06 11:54:41 PST
WebKit2 unit tests for GTK+ did follow WebKit coding style in the past, but they do now. We should update the style bot to check these files.
Comment 1 Martin Robinson 2012-02-06 12:08:43 PST
Created attachment 125684 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-06 12:13:23 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Martin Robinson 2012-02-06 12:16:09 PST
Created attachment 125685 [details]
Do not unskip WebKit1 tests
Comment 4 Gustavo Noronha (kov) 2012-02-06 12:19:22 PST
Comment on attachment 125685 [details]
Do not unskip WebKit1 tests

r=me
Comment 5 WebKit Review Bot 2012-02-06 13:01:43 PST
Comment on attachment 125685 [details]
Do not unskip WebKit1 tests

Clearing flags on attachment: 125685

Committed r106838: <http://trac.webkit.org/changeset/106838>
Comment 6 WebKit Review Bot 2012-02-06 13:01:48 PST
All reviewed patches have been landed.  Closing bug.