RESOLVED FIXED Bug 77877
Web Inspector: don't mark object is queriable if it is only reachable by internal reference 
https://bugs.webkit.org/show_bug.cgi?id=77877
Summary Web Inspector: don't mark object is queriable if it is only reachable by inte...
Yury Semikhatsky
Reported 2012-02-06 08:29:10 PST
Web Inspector: don't mark object is queriable if it is only reachable by internal reference
Attachments
Patch (2.00 KB, patch)
2012-02-06 08:32 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (1.81 KB, patch)
2012-02-06 08:41 PST, Yury Semikhatsky 		pfeldman: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-02-06 08:32:09 PST
Created attachment 125655 [details] Patch
Mikhail Naganov
Comment 2 2012-02-06 08:35:20 PST
Comment on attachment 125655 [details] Patch looks good to me
Ilya Tikhonovsky
Comment 3 2012-02-06 08:41:15 PST
Comment on attachment 125655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125655&action=review > Source/WebCore/inspector/front-end/HeapSnapshot.js:-1127 > - if (this._flags[node.nodeIndex] & flag) > - continue; this is necessary check. please revert this.
Yury Semikhatsky
Comment 4 2012-02-06 08:41:29 PST
Created attachment 125656 [details] Patch
Ilya Tikhonovsky
Comment 5 2012-02-06 08:42:48 PST
Comment on attachment 125656 [details] Patch looks good to me
WebKit Review Bot
Comment 6 2012-02-06 09:11:59 PST
Comment on attachment 125656 [details] Patch Attachment 125656 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11430457 New failing tests: inspector/profiler/heap-snapshot.html
Yury Semikhatsky
Comment 7 2012-02-07 04:53:12 PST
Committed r106928: <http://trac.webkit.org/changeset/106928>
Note You need to log in before you can comment on or make changes to this bug.