Bug 77877 - Web Inspector: don't mark object is queriable if it is only reachable by internal reference
Summary: Web Inspector: don't mark object is queriable if it is only reachable by inte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-06 08:29 PST by Yury Semikhatsky
Modified: 2012-02-07 04:53 PST (History)
12 users (show)

See Also:

Attachments
Patch (2.00 KB, patch)
2012-02-06 08:32 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (1.81 KB, patch)
2012-02-06 08:41 PST, Yury Semikhatsky 		pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-02-06 08:29:10 PST 
Web Inspector: don't mark object is queriable if it is only reachable by internal reference
Comment 1 Yury Semikhatsky 2012-02-06 08:32:09 PST 
Created attachment 125655 [details]
Patch
Comment 2 Mikhail Naganov 2012-02-06 08:35:20 PST 
Comment on attachment 125655 [details]
Patch

looks good to me
Comment 3 Ilya Tikhonovsky 2012-02-06 08:41:15 PST 
Comment on attachment 125655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125655&action=review

> Source/WebCore/inspector/front-end/HeapSnapshot.js:-1127
> -            if (this._flags[node.nodeIndex] & flag)
> -                continue;

this is necessary check. please revert this.
Comment 4 Yury Semikhatsky 2012-02-06 08:41:29 PST 
Created attachment 125656 [details]
Patch
Comment 5 Ilya Tikhonovsky 2012-02-06 08:42:48 PST 
Comment on attachment 125656 [details]
Patch

looks good to me
Comment 6 WebKit Review Bot 2012-02-06 09:11:59 PST 
Comment on attachment 125656 [details]
Patch

Attachment 125656 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11430457

New failing tests:
inspector/profiler/heap-snapshot.html
Comment 7 Yury Semikhatsky 2012-02-07 04:53:12 PST 
Committed r106928: <http://trac.webkit.org/changeset/106928>