WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
77866
[webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
https://bugs.webkit.org/show_bug.cgi?id=77866
Summary
[webkitpy] cpp style-checker complains about readability/naming in GStreamer ...
Philippe Normand
Reported
2012-02-06 05:21:28 PST
These files define GObjects, which implies some definitions of variables and functions containing underscores.
Attachments
Patch
(2.85 KB, patch)
2012-02-06 05:29 PST
,
Philippe Normand
mrobinson
: review+
mrobinson
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Philippe Normand
Comment 1
2012-02-06 05:29:08 PST
Created
attachment 125624
[details]
Patch
WebKit Review Bot
Comment 2
2012-02-06 05:30:28 PST
Attachment 125624
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/style/checker.py:215: missing whitespace after ',' [pep8/E231] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Martin Robinson
Comment 3
2012-02-06 09:10:02 PST
Comment on
attachment 125624
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=125624&action=review
>> Tools/Scripts/webkitpy/style/checker.py:215 >> + ["-readability/naming",]), > > missing whitespace after ',' [pep8/E231] [5]
I think you can just remove the interior comma to make the style bot happy.
Philippe Normand
Comment 4
2012-02-06 09:35:52 PST
Committed
r106814
: <
http://trac.webkit.org/changeset/106814
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug