Bug 77861 - HasIDFlag and HasClassFlag can be removed.
Summary: HasIDFlag and HasClassFlag can be removed.
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
Depends on: 78070
Blocks: 77860
  Show dependency treegraph
Reported: 2012-02-06 02:20 PST by Hajime Morrita
Modified: 2012-02-21 23:21 PST (History)
2 users (show)

See Also:

Patch (8.59 KB, patch)
2012-02-08 17:50 PST, Hajime Morrita
kling: review+
morrita: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-02-06 02:20:05 PST
Node::HasIDFlag and Node::HasClassFlag can be replaced with ElementAttributeData,
which doesn't need any hashtable lookup.
Comment 1 Hajime Morrita 2012-02-08 17:50:13 PST
Created attachment 126208 [details]
Comment 2 Hajime Morrita 2012-02-08 17:51:45 PST
Ryosuke, Andreas, could you take a look?
Note that I don't see any significant performance impact on Dromaeo.
Comment 3 Andreas Kling 2012-02-08 17:56:33 PST
Comment on attachment 126208 [details]

Great idea! r=me
Comment 4 Hajime Morrita 2012-02-08 18:01:10 PST
Waiting Bug 78070 is resolved as rniwa's suggestion at irc.
Comment 5 Hajime Morrita 2012-02-21 23:21:23 PST
Committed r108449: <http://trac.webkit.org/changeset/108449>