Bug 77852 - Rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet], [DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs
Summary: Rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet], [DoNo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 77393
  Show dependency treegraph
 
Reported: 2012-02-05 22:48 PST by Kentaro Hara
Modified: 2012-02-06 18:43 PST (History)
8 users (show)

See Also:


Attachments
Patch (51.65 KB, patch)
2012-02-05 22:55 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
rebased patch for commit (52.05 KB, patch)
2012-02-06 17:31 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
rebased patch for commit (51.56 KB, patch)
2012-02-06 18:41 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-05 22:48:46 PST
We can rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet], [DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs for clarification.

[DontCheckEnums] => [DoNotCheckConstants]  (This IDL inserts assertions to check if a constant value are equal to the expected constant value)
[ReturnsNew] => [ReturnNewObject] (For clarification)
[DoNotCheckDomainSecurityOnGet] => [DoNotCheckDomainSecurityOnGetter] (For naming consistency with other [*Getter] IDLs)
[DoNotCheckDomainSecurityOnSet] => [DoNotCheckDomainSecurityOnSetter] (For naming consistency with other [*Setter] IDLs)
[ImplementationFunction=] => [ImplementedAs=] (For clarification. This IDL specifies the method name in implementation)
Comment 1 Kentaro Hara 2012-02-05 22:55:56 PST
Created attachment 125577 [details]
Patch
Comment 2 Kentaro Hara 2012-02-06 17:31:34 PST
Created attachment 125737 [details]
rebased patch for commit
Comment 3 Kentaro Hara 2012-02-06 17:33:56 PST
Committed r106883: <http://trac.webkit.org/changeset/106883>
Comment 4 Kentaro Hara 2012-02-06 17:34:41 PST
Comment on attachment 125577 [details]
Patch

Landed manually to avoid style check errors in generated code for GTK.
Comment 5 Kentaro Hara 2012-02-06 18:04:42 PST
Reverted r106883 for reason:

build failure around Chromium V8 bindings

Committed r106889: <http://trac.webkit.org/changeset/106889>
Comment 6 Kentaro Hara 2012-02-06 18:41:32 PST
Created attachment 125749 [details]
rebased patch for commit
Comment 7 Kentaro Hara 2012-02-06 18:43:53 PST
Committed r106892: <http://trac.webkit.org/changeset/106892>