Bug 77850 - Web Inspector: get rid of artificial heap snapshot nodes from the retaining tree.
Summary: Web Inspector: get rid of artificial heap snapshot nodes from the retaining t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks: 78411
  Show dependency treegraph
 
Reported: 2012-02-05 22:06 PST by Ilya Tikhonovsky
Modified: 2012-02-11 01:26 PST (History)
10 users (show)

See Also:


Attachments
Patch (4.73 KB, patch)
2012-02-05 22:11 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (4.73 KB, patch)
2012-02-05 23:26 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-02-05 22:06:44 PST
%subj%
Comment 1 Ilya Tikhonovsky 2012-02-05 22:11:10 PST
Created attachment 125572 [details]
Patch
Comment 2 Yury Semikhatsky 2012-02-05 23:18:03 PST
Comment on attachment 125572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125572&action=review

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:399
> +            "        && (" + !this.showRetainingEdges + " || (!edge.node.id !== 1 && !edge.node.isArtificial))\n" +

!edge.node.id !== 1 will always evaluate to true, r- for this.
Comment 3 Ilya Tikhonovsky 2012-02-05 23:26:06 PST
Created attachment 125580 [details]
Patch
Comment 4 Ilya Tikhonovsky 2012-02-05 23:53:15 PST
Comment on attachment 125580 [details]
Patch

Clearing flags on attachment: 125580

Committed r106778: <http://trac.webkit.org/changeset/106778>
Comment 5 Ilya Tikhonovsky 2012-02-05 23:53:24 PST
All reviewed patches have been landed.  Closing bug.