Bug 77848 - Rename [HasIndexGetter], [HasNameGetter] and [HasCustomIndexSetter] IDLs
Summary: Rename [HasIndexGetter], [HasNameGetter] and [HasCustomIndexSetter] IDLs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 77393
  Show dependency treegraph
 
Reported: 2012-02-05 21:36 PST by Kentaro Hara
Modified: 2012-02-06 05:01 PST (History)
8 users (show)

See Also:


Attachments
Patch (49.19 KB, patch)
2012-02-05 21:57 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
patch for commit (49.00 KB, patch)
2012-02-06 03:17 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
patch for commit (48.99 KB, patch)
2012-02-06 03:18 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-05 21:36:03 PST
For naming consistency with [CustomGetter] and [CustomSetter], we can rename the following IDLs:

[HasIndexGetter] => [IndexedGetter]  (Remove "Has". This IDL is for "indexed" properties in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-indexed-properties)
[HasCustomIndexSetter] => [CustomIndexedSetter]  (Ditto.)
[HasNameGetter] => [NamedGetter] (Remove "Has". This IDL is for "named" properties in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-named-properties)
Comment 1 Kentaro Hara 2012-02-05 21:57:05 PST
Created attachment 125569 [details]
Patch
Comment 2 Adam Barth 2012-02-05 22:12:27 PST
Comment on attachment 125569 [details]
Patch

Ok.  Ideally we'd match the WebIDL syntax.
Comment 3 WebKit Review Bot 2012-02-06 01:21:29 PST
Comment on attachment 125569 [details]
Patch

Rejecting attachment 125569 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 10594 --non-interactive --force --accept theirs-conflict --ignore-externals returned non-zero exit status 1 in /mnt/git/webkit-commit-queue/Source/WebKit/chromium
Error: 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 106.
Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees'
No such file or directory at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2370.

Full output: http://queues.webkit.org/results/11434206
Comment 4 Kentaro Hara 2012-02-06 03:17:26 PST
Created attachment 125609 [details]
patch for commit
Comment 5 Kentaro Hara 2012-02-06 03:18:59 PST
Created attachment 125610 [details]
patch for commit
Comment 6 WebKit Review Bot 2012-02-06 04:56:26 PST
Comment on attachment 125610 [details]
patch for commit

Clearing flags on attachment: 125610

Committed r106798: <http://trac.webkit.org/changeset/106798>