Bug 77842 - [EFL] Define to prevent a single backing-store application from calling the tiled view function.
Summary: [EFL] Define to prevent a single backing-store application from calling the t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-05 17:52 PST by JungJik Lee
Modified: 2012-02-06 23:22 PST (History)
5 users (show)

See Also:


Attachments
proposal patch (3.80 KB, patch)
2012-02-05 18:01 PST, JungJik Lee
no flags Details | Formatted Diff | Diff
revised_patch_1 (3.79 KB, patch)
2012-02-06 04:40 PST, JungJik Lee
kling: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
revised_patch_2 (3.88 KB, patch)
2012-02-06 22:59 PST, JungJik Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JungJik Lee 2012-02-05 17:52:48 PST
The define prevents an application using single backing store from calling tiled cache function.
The tiled APIs opened to outer should check the view type before being called.
Comment 1 JungJik Lee 2012-02-05 18:01:51 PST
Created attachment 125548 [details]
proposal patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-02-06 04:07:52 PST
Comment on attachment 125548 [details]
proposal patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125548&action=review

Looks OK.

> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:396
> +

No need for this extra line.

> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:405
> +

Ditto.
Comment 3 JungJik Lee 2012-02-06 04:40:07 PST
Created attachment 125616 [details]
revised_patch_1

remove unnecessary lines.
Comment 4 JungJik Lee 2012-02-06 04:40:43 PST
Comment on attachment 125548 [details]
proposal patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125548&action=review

>> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:396
>> +
> 
> No need for this extra line.

done!

>> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:405
>> +
> 
> Ditto.

done!
Comment 5 KwangHyuk 2012-02-06 14:34:03 PST
LGTM.
Comment 6 WebKit Review Bot 2012-02-06 22:36:25 PST
Comment on attachment 125616 [details]
revised_patch_1

Rejecting attachment 125616 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10594 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 10594.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11439158
Comment 7 JungJik Lee 2012-02-06 22:59:28 PST
Created attachment 125770 [details]
revised_patch_2

Due to conflict with previous patch, I filed new rebased patch.
Comment 8 WebKit Review Bot 2012-02-06 23:22:50 PST
Comment on attachment 125770 [details]
revised_patch_2

Clearing flags on attachment: 125770

Committed r106908: <http://trac.webkit.org/changeset/106908>
Comment 9 WebKit Review Bot 2012-02-06 23:22:55 PST
All reviewed patches have been landed.  Closing bug.