Bug 77840 - The scrolling tree should be aware of any wheel event handlers on the page
Summary: The scrolling tree should be aware of any wheel event handlers on the page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-05 16:31 PST by Anders Carlsson
Modified: 2012-02-06 10:35 PST (History)
5 users (show)

See Also:


Attachments
Patch (10.52 KB, patch)
2012-02-05 16:33 PST, Anders Carlsson
kling: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-02-05 16:31:25 PST
The scrolling tree should be aware of any wheel event handlers on the page
Comment 1 Anders Carlsson 2012-02-05 16:33:27 PST
Created attachment 125542 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-05 16:38:12 PST
Comment on attachment 125542 [details]
Patch

Attachment 125542 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11432060
Comment 3 Andreas Kling 2012-02-05 16:42:24 PST
Comment on attachment 125542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125542&action=review

r=me with cr build fixed.

> Source/WebCore/page/scrolling/ScrollingTree.cpp:92
> +    if (scrollingTreeState->changedProperties() | ScrollingTreeState::WheelEventHandlerCount) {

You want & here.
Comment 4 Andreas Kling 2012-02-05 17:03:15 PST
<http://trac.webkit.org/changeset/106766>
Comment 6 Raymond 2012-02-05 17:38:18 PST
Comment on attachment 125542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125542&action=review

> Source/WebCore/dom/Document.cpp:5381
> +    UNUSED_PARAM(document)

On my machine this break build

UNUSED_PARAM(document) ->  UNUSED_PARAM(document);

While this can got build on buildbot?
Comment 8 Anders Carlsson 2012-02-06 10:35:01 PST
Committed r106766: <http://trac.webkit.org/changeset/106766>