WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
77840
The scrolling tree should be aware of any wheel event handlers on the page
https://bugs.webkit.org/show_bug.cgi?id=77840
Summary
The scrolling tree should be aware of any wheel event handlers on the page
Anders Carlsson
Reported
2012-02-05 16:31:25 PST
The scrolling tree should be aware of any wheel event handlers on the page
Attachments
Patch
(10.52 KB, patch)
2012-02-05 16:33 PST
,
Anders Carlsson
kling
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2012-02-05 16:33:27 PST
Created
attachment 125542
[details]
Patch
WebKit Review Bot
Comment 2
2012-02-05 16:38:12 PST
Comment on
attachment 125542
[details]
Patch
Attachment 125542
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/11432060
Andreas Kling
Comment 3
2012-02-05 16:42:24 PST
Comment on
attachment 125542
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=125542&action=review
r=me with cr build fixed.
> Source/WebCore/page/scrolling/ScrollingTree.cpp:92 > + if (scrollingTreeState->changedProperties() | ScrollingTreeState::WheelEventHandlerCount) {
You want & here.
Andreas Kling
Comment 4
2012-02-05 17:03:15 PST
<
http://trac.webkit.org/changeset/106766
>
Andreas Kling
Comment 5
2012-02-05 17:35:11 PST
http://trac.webkit.org/changeset/106767/trunk/Source/WebCore/dom/Document.cpp
->
http://redct.info/reddit/ragefriends/requests/harpdarp.svg
Raymond
Comment 6
2012-02-05 17:38:18 PST
Comment on
attachment 125542
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=125542&action=review
> Source/WebCore/dom/Document.cpp:5381 > + UNUSED_PARAM(document)
On my machine this break build UNUSED_PARAM(document) -> UNUSED_PARAM(document); While this can got build on buildbot?
Raymond
Comment 7
2012-02-05 17:40:08 PST
(In reply to
comment #5
)
>
http://trac.webkit.org/changeset/106767/trunk/Source/WebCore/dom/Document.cpp
->
http://redct.info/reddit/ragefriends/requests/harpdarp.svg
ok. I am late.
Anders Carlsson
Comment 8
2012-02-06 10:35:01 PST
Committed
r106766
: <
http://trac.webkit.org/changeset/106766
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug