Bug 77839 - Web Inspector: Fix CallArgument type in Inspector.json
Summary: Web Inspector: Fix CallArgument type in Inspector.json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-05 16:09 PST by Peter Rybin
Modified: 2012-02-06 01:28 PST (History)
12 users (show)

See Also:


Attachments
Patch (3.63 KB, patch)
2012-02-05 16:19 PST, Peter Rybin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Rybin 2012-02-05 16:09:46 PST
Currently CallArgument has the following field:

{ "name": "objectId", "$ref": "RemoteObject", "optional": true, "description": "Remote object handle." }

The field name doesn't conform to field value type.
Field type should be fixed to a correct "RemoteObjectId" which has always been expected in the InjectedScriptSource.js implementation.

See also https://bugs.webkit.org/show_bug.cgi?id=74110
Comment 1 Peter Rybin 2012-02-05 16:15:21 PST
Inspector.json should be fixed.
Inspector-0.1.json and Inspector-1.0.json should also be retroactively fixed.
Comment 2 Peter Rybin 2012-02-05 16:19:12 PST
Created attachment 125540 [details]
Patch
Comment 3 WebKit Review Bot 2012-02-06 01:28:03 PST
Comment on attachment 125540 [details]
Patch

Clearing flags on attachment: 125540

Committed r106787: <http://trac.webkit.org/changeset/106787>
Comment 4 WebKit Review Bot 2012-02-06 01:28:08 PST
All reviewed patches have been landed.  Closing bug.