Bug 77832 – [Gtk] compilation error in WebCore/platform/graphics/pango/FontPlatformData.h

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

When trying to cross compile WebkitGtk for windows with build options being:

--with-target=win32 --with-gtk=2.0 --with-font-backend=pango --with-unicode-backend=icu

i get compilation error in --with-target=win32 --with-gtk=2.0 --with-font-backend=pango --with-unicode-backend=icu


./Source/WebCore/platform/graphics/pango/FontPlatformData.h:32:30: fatal error: pango/pangocairo.h: No such file or directory

Last lines printed by make

  CXX    Source/WebCore/accessibility/libWebCore_la-AccessibilityARIAGridCell.lo
  CXX    Source/WebCore/accessibility/libWebCore_la-AccessibilityARIAGrid.lo
In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/libsoup-2.4/libsoup/soup-portability.h:13:0,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/libsoup-2.4/libsoup/soup-address.h:11,
                 from /usr/i686-w64-mingw32/sys-root/mingw/include/libsoup-2.4/libsoup/soup.h:13,
                 from ./Source/WebCore/platform/network/soup/ResourceResponse.h:31,
                 from ./Source/WebCore/platform/network/AuthenticationChallengeBase.h:30,
                 from ./Source/WebCore/platform/network/soup/AuthenticationChallenge.h:28,
                 from ./Source/WebCore/platform/network/ResourceHandle.h:29,
                 from ./Source/WebCore/loader/ResourceLoaderOptions.h:34,
                 from ./Source/WebCore/loader/cache/CachedResource.h:30,
                 from ./Source/WebCore/loader/cache/CachedImage.h:26,
                 from ./Source/WebCore/rendering/RenderObject.h:29,
                 from Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:37:
/usr/i686-w64-mingw32/sys-root/mingw/include/winsock2.h:15:2: warning: #warning Please include winsock2.h before windows.h [-Wcpp]
In file included from ./Source/WebCore/platform/graphics/FontPlatformData.h:37:0,
                 from ./Source/WebCore/platform/graphics/SimpleFontData.h:30,
                 from ./Source/WebCore/platform/graphics/FontFallbackList.h:25,
                 from ./Source/WebCore/platform/graphics/Font.h:29,
                 from ./Source/WebCore/rendering/style/RenderStyle.h:38,
                 from ./Source/WebCore/rendering/RenderObject.h:36,
                 from Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:37:
./Source/WebCore/platform/graphics/pango/FontPlatformData.h:32:30: fatal error: pango/pangocairo.h: No such file or directory
compilation terminated.
make[1]: *** [Source/WebCore/accessibility/libWebCore_la-AccessibilityARIAGrid.lo] Error 1
make[1]: Leaving directory `/home/pawel/src/WebKit'
make: *** [all] Error 2

[Kalev Lember]

Created attachment 125525 [details]
Patch to add missing $(PANGO_CFLAGS) to relevant places

I can confirm that patch attached above fixes this issue.

[WebKit Review Bot]

Comment on attachment 125525 [details]
Patch to add missing $(PANGO_CFLAGS) to relevant places

Clearing flags on attachment: 125525

Committed r106847: <http://trac.webkit.org/changeset/106847>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.