WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
77827
Remove mapped vs non-mapped attribute distinction.
https://bugs.webkit.org/show_bug.cgi?id=77827
Summary
Remove mapped vs non-mapped attribute distinction.
Andreas Kling
Reported
2012-02-05 01:06:02 PST
This stuff is confusing at best.
Attachments
Possibly a patch
(13.92 KB, patch)
2012-02-05 01:13 PST
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2012-02-05 01:13:15 PST
Created
attachment 125522
[details]
Possibly a patch
Antti Koivisto
Comment 2
2012-02-05 01:15:18 PST
Comment on
attachment 125522
[details]
Possibly a patch r=me
Andreas Kling
Comment 3
2012-02-05 01:26:12 PST
Comment on
attachment 125522
[details]
Possibly a patch Clearing flags on attachment: 125522 Committed
r106757
: <
http://trac.webkit.org/changeset/106757
>
Andreas Kling
Comment 4
2012-02-05 01:26:20 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5
2012-02-06 15:05:25 PST
> Previously, StyledElement would generate mapped > attributes and plain Element would generate non-mapped ones.
Somehow I thought that mapped attributes were ones that were mapped to CSS (like "dir"), in contrast to ones like "onload". Was I horribly confused (at best)?
Andreas Kling
Comment 6
2012-02-06 15:21:07 PST
(In reply to
comment #5
)
> > Previously, StyledElement would generate mapped > > attributes and plain Element would generate non-mapped ones. > > Somehow I thought that mapped attributes were ones that were mapped to CSS (like "dir"), in contrast to ones like "onload". Was I horribly confused (at best)?
Yeah, I think both of us were. I suspect that was the intended meaning back in KHTML times. Mapped attributes have been coming out of StyledElement::createAttribute() and non-mapped ones from Element::createAttribute(). It made a bit more sense before Attribute and MappedAttribute were merged into one class by Anders (IIRC) some years ago, since before then only a MappedAttribute had a style declaration.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug