Bug 77815 - CSSStyleSelector: Remove garbage collection of cached matched declarations.
Summary: CSSStyleSelector: Remove garbage collection of cached matched declarations.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-04 15:25 PST by Andreas Kling
Modified: 2012-03-14 15:57 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.06 KB, patch)
2012-02-04 15:26 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-02-04 15:25:46 PST 
After removing per-Attribute style declarations, we don't need to GC the matched declaration cache anymore.
Comment 1 Andreas Kling 2012-02-04 15:26:57 PST 
Created attachment 125503 [details]
Patch
Comment 2 Antti Koivisto 2012-02-05 00:50:08 PST 
Comment on attachment 125503 [details]
Patch

Asserting that we have nothing in the cache that is kept alive by it only would be good. We might end up putting this back in if we again start caching something that is not tied to the style selector life time...
Comment 3 Andreas Kling 2012-02-05 18:17:17 PST 
Comment on attachment 125503 [details]
Patch

Clearing r? since Antti brings up a sort-of reason to keep this code around for now.
Comment 4 Andreas Kling 2012-03-14 15:57:55 PDT 
We need this for now.