Bug 77810 - Web Inspector: beautify retaining tree items view
Summary: Web Inspector: beautify retaining tree items view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks: 78411
  Show dependency treegraph
 
Reported: 2012-02-04 05:41 PST by Ilya Tikhonovsky
Modified: 2012-02-11 01:26 PST (History)
10 users (show)

See Also:


Attachments
screenshot (128.22 KB, image/png)
2012-02-04 05:43 PST, Ilya Tikhonovsky
no flags Details
Patch (6.12 KB, patch)
2012-02-04 06:35 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (4.02 KB, patch)
2012-02-05 00:22 PST, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-02-04 05:41:03 PST
%subj%
Comment 1 Ilya Tikhonovsky 2012-02-04 05:43:30 PST
Created attachment 125494 [details]
screenshot
Comment 2 Ilya Tikhonovsky 2012-02-04 06:35:31 PST
Created attachment 125496 [details]
Patch
Comment 3 Yury Semikhatsky 2012-02-04 23:42:01 PST
Comment on attachment 125496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125496&action=review

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:399
> +            "        && (" + !this.showRetainingEdges + " || (!edge.isInternal && edge.nodeIndex !== 1))\n" +

I don't think we want to omit internal references like 'native' in the retainers path, some of them may be real retainers interesting for the user especially wheh there is no other retainer.  I think the condition should be more selective.
Comment 4 Ilya Tikhonovsky 2012-02-05 00:22:22 PST
Created attachment 125519 [details]
Patch
Comment 5 Ilya Tikhonovsky 2012-02-05 00:27:25 PST
Committed r106755: <http://trac.webkit.org/changeset/106755>