Bug 77805 – Port some indexeddb layout tests to workers.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[David Grogan]

port some idb layout tests to workers

[David Grogan]

Created attachment 125477 [details]
Patch

[David Grogan]

Created attachment 125681 [details]
Patch

[David Grogan]

Comment on attachment 125681 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125681&action=review

Josh, do you know what's going on with DOMException here?

> LayoutTests/storage/indexeddb/objectstore-basics-expected.txt:84
> +PASS code is 25

DOMException.DATA_CLONE_ERR is the only problem I've run into so far - JS from workers thinks it is undefined.

> LayoutTests/storage/indexeddb/objectstore-basics-workers-expected.txt:85
> +FAIL [Worker] code should be 25 (of type number). Was undefined (of type undefined).

And undefined is propogated out anyway.

[Joshua Bell]

Comment on attachment 125681 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125681&action=review

> LayoutTests/storage/indexeddb/resources/objectstore-basics.js:168
> +        store.add({x: 'bar', y: document.getElementById('console')}, 'bar');

Discussed this offline, but for the record:

The "document" reference here will fail as undefined in workers. Since this is just trying to grab an object that can't be cloned, replace "document.getElementById('console')" with "self"

> LayoutTests/storage/indexeddb/resources/objectstore-basics.js:173
> +        shouldBe("code", "25");

... and DOMException itself will be undefined, so we probably need to leave this as 25. Add a FIXME indicating that when we move to DOM4-style exceptions this should look for the name "DataCloneError"

[David Grogan]

Created attachment 125703 [details]
Patch

[David Grogan]

Comment on attachment 125703 [details]
Patch

This patch fixes the non-cloneable test to use 'self' and the worker version now passes.

[David Grogan]

Created attachment 125712 [details]
Patch

[David Grogan]

Tony, could you review this patch?

[David Grogan]

*** Bug 73297 has been marked as a duplicate of this bug. ***

[WebKit Review Bot]

Comment on attachment 125712 [details]
Patch

Clearing flags on attachment: 125712

Committed r106886: <http://trac.webkit.org/changeset/106886>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.