Bug 77801 – Web Inspector: get rid of cycles in retaining tree

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

%subj%

[Ilya Tikhonovsky]

Created attachment 125473 [details]
Patch

[WebKit Review Bot]

Comment on attachment 125473 [details]
Patch

Attachment 125473 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11418649

New failing tests:
inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html
inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting.html

[Yury Semikhatsky]

Comment on attachment 125473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125473&action=review

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:380
> +            while (ancestor) {

We may stop if the parentGridNode already has _cycledWithAncestorGridNode set.

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:388
> +        WebInspector.HeapSnapshotGenericObjectNode.prototype._updateHasChildren.call(this);

Please remvoe leading underscore from _updateHasChildren  method name since you override it, by the convention only private methods should start with _.

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:-444
> -            prefixSpan.textContent = WebInspector.UIString("retained by ");

Please mention this UI change in the changelog.

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:458
> +        if (this._cycledWithAncestorGridNode) {

We need some UI for navigating to the first occurrence of the node in the ancesors chain but this can be done in a separate patch.

[Ilya Tikhonovsky]

Committed r106738: <http://trac.webkit.org/changeset/106738>

[Ilya Tikhonovsky]

Created attachment 125492 [details]
the patch that was actually landed