Bug 77798 - Convert PopupMenuClient::clientPadding over to LayoutUnit
Summary: Convert PopupMenuClient::clientPadding over to LayoutUnit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-02-03 19:01 PST by Emil A Eklund
Modified: 2012-02-06 17:08 PST (History)
6 users (show)

See Also:

Attachments
Patch (7.20 KB, patch)
2012-02-03 19:03 PST, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Patch (8.37 KB, patch)
2012-02-03 20:15 PST, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-02-03 19:01:00 PST 
Change PopupMenuClient and all classes inheriting from it to use the new layout types for padding.
Comment 1 Emil A Eklund 2012-02-03 19:03:37 PST 
Created attachment 125464 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-03 19:12:39 PST 
Comment on attachment 125464 [details]
Patch

Attachment 125464 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11419573
Comment 3 Emil A Eklund 2012-02-03 20:15:06 PST 
Created attachment 125472 [details]
Patch
Comment 4 Eric Seidel (no email) 2012-02-03 21:20:45 PST 
Comment on attachment 125472 [details]
Patch

This feels slightly odd, since I wouldn't expect most embedders to render popup menus with sub-pixel precision, but I guess with a scalable UI there is no reason why they wouldn't.
Comment 5 Emil A Eklund 2012-02-06 15:20:51 PST 
All other paddings are being converted to LayoutUnit so it made sense to change this to be consistent. In all likelihood platforms will still return integer values though.
Comment 6 WebKit Review Bot 2012-02-06 17:08:20 PST 
Comment on attachment 125472 [details]
Patch

Clearing flags on attachment: 125472

Committed r106880: <http://trac.webkit.org/changeset/106880>
Comment 7 WebKit Review Bot 2012-02-06 17:08:25 PST 
All reviewed patches have been landed.  Closing bug.