Bug 77780 - Commit scrolling tree state changes to the scrolling tree
Summary: Commit scrolling tree state changes to the scrolling tree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-03 14:31 PST by Anders Carlsson
Modified: 2012-02-03 14:47 PST (History)
0 users

See Also:


Attachments
Patch (19.86 KB, patch)
2012-02-03 14:37 PST, Anders Carlsson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-02-03 14:31:24 PST
Commit scrolling tree state changes to the scrolling tree
Comment 1 Anders Carlsson 2012-02-03 14:37:46 PST
Created attachment 125416 [details]
Patch
Comment 2 Darin Adler 2012-02-03 14:40:30 PST
Comment on attachment 125416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125416&action=review

> Source/WebCore/page/scrolling/ScrollingTree.cpp:68
> +    OwnPtr<ScrollingTreeState> newScrollingTreeState = scrollingTreeState;
> +    m_rootNode->update(newScrollingTreeState.get());

I don’t think we need the local variable.

> Source/WebCore/page/scrolling/mac/ScrollingTreeNodeMac.h:42
> +    RetainPtr<CALayer> m_scrollLayer;

public data member?
Comment 3 Anders Carlsson 2012-02-03 14:47:11 PST
Committed r106696: <http://trac.webkit.org/changeset/106696>